media: i2c: imx500: pm_runtime error paths

This change amends various error-paths in imx500_start_streaming() to
ensure that pm_runtime refcounts do not remain erroneously incremented
on failure.

Signed-off-by: Richard Oliver <richard.oliver@raspberrypi.com>

Author: roliver-rpi

drivers/media/i2c/imx500.c

@@ -2572,7 +2572,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 	if (ret) {
 		dev_err(&client->dev, "%s failed to set image mode\n",
 			__func__);
-		return ret;
+		goto err_runtime_put;
 	}
 
 	/* Acquire loader and main firmware if needed */
@@ -2584,7 +2584,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 			if (ret) {
 				dev_err(&client->dev,
 					"Unable to acquire firmware loader\n");
-				return ret;
+				goto err_runtime_put;
 			}
 		}
 		if (!imx500->fw_main) {
@@ -2594,7 +2594,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 			if (ret) {
 				dev_err(&client->dev,
 					"Unable to acquire main firmware\n");
-				return ret;
+				goto err_runtime_put;
 			}
 		}
 	}
@@ -2606,7 +2606,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 		if (ret) {
 			dev_err(&client->dev,
 				"%s failed to set common settings\n", __func__);
-			return ret;
+			goto err_runtime_put;
 		}
 
 		imx500->common_regs_written = true;
@@ -2618,7 +2618,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 			dev_err(&client->dev,
 				"%s failed to transition from program empty state\n",
 				__func__);
-			return ret;
+			goto err_runtime_put;
 		}
 		imx500->loader_and_main_written = true;
 	}
@@ -2629,7 +2629,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 			dev_err(&client->dev,
 				"%s failed to transition to network loaded\n",
 				__func__);
-			return ret;
+			goto err_runtime_put;
 		}
 		imx500->network_written = true;
 	}
@@ -2640,7 +2640,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 		if (ret) {
 			dev_err(&client->dev, "%s failed to enable DNN\n",
 				__func__);
-			return ret;
+			goto err_runtime_put;
 		}
 
 		v4l2_ctrl_activate(imx500->device_id, true);
@@ -2652,7 +2652,7 @@ static int imx500_start_streaming(struct imx500 *imx500)
 				  reg_list->num_of_regs, NULL);
 	if (ret) {
 		dev_err(&client->dev, "%s failed to set mode\n", __func__);
-		return ret;
+		goto err_runtime_put;
 	}
 
 	/* Apply customized values from user */
@@ -2668,6 +2668,14 @@ static int imx500_start_streaming(struct imx500 *imx500)
 	cci_write(imx500->regmap, IMX500_REG_MODE_SELECT, IMX500_MODE_STREAMING,
 		  &ret);
 
+	if (ret)
+		goto err_runtime_put;
+
+	return 0;
+
+err_runtime_put:
+	pm_runtime_mark_last_busy(&client->dev);
+	pm_runtime_put_autosuspend(&client->dev);
 	return ret;
 }