Skip to content

Commit b5fcf6e

Browse files
vlrplnbuchwitz
authored andcommitted
net: macb: rename rx_skbuff into rx_buff
This is a preparation commit as the field in later patches will no longer accomomdate skbuffs, but more generic frames. Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
1 parent e4bdd11 commit b5fcf6e

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

drivers/net/ethernet/cadence/macb.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1301,7 +1301,7 @@ struct macb_queue {
13011301
unsigned int rx_tail;
13021302
unsigned int rx_prepared_head;
13031303
struct macb_dma_desc *rx_ring;
1304-
struct sk_buff **rx_skbuff;
1304+
void **rx_buff;
13051305
void *rx_buffers;
13061306
struct napi_struct napi_rx;
13071307
struct queue_stats stats;

drivers/net/ethernet/cadence/macb_main.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,7 +1442,7 @@ static int gem_rx_refill(struct macb_queue *queue)
14421442

14431443
desc = macb_rx_desc(queue, entry);
14441444

1445-
if (!queue->rx_skbuff[entry]) {
1445+
if (!queue->rx_buff[entry]) {
14461446
/* allocate sk_buff for this free entry in ring */
14471447
skb = netdev_alloc_skb(bp->dev, bp->rx_buffer_size);
14481448
if (unlikely(!skb)) {
@@ -1461,7 +1461,7 @@ static int gem_rx_refill(struct macb_queue *queue)
14611461
break;
14621462
}
14631463

1464-
queue->rx_skbuff[entry] = skb;
1464+
queue->rx_buff[entry] = skb;
14651465

14661466
if (entry == bp->rx_ring_size - 1)
14671467
paddr |= MACB_BIT(RX_WRAP);
@@ -1553,7 +1553,7 @@ static int gem_rx(struct macb_queue *queue, struct napi_struct *napi,
15531553
queue->stats.rx_dropped++;
15541554
break;
15551555
}
1556-
skb = queue->rx_skbuff[entry];
1556+
skb = queue->rx_buff[entry];
15571557
if (unlikely(!skb)) {
15581558
netdev_err(bp->dev,
15591559
"inconsistent Rx descriptor chain\n");
@@ -1562,7 +1562,7 @@ static int gem_rx(struct macb_queue *queue, struct napi_struct *napi,
15621562
break;
15631563
}
15641564
/* now everything is ready for receiving packet */
1565-
queue->rx_skbuff[entry] = NULL;
1565+
queue->rx_buff[entry] = NULL;
15661566
len = ctrl & bp->rx_frm_len_mask;
15671567

15681568
netdev_vdbg(bp->dev, "gem_rx %u (len %u)\n", entry, len);
@@ -2581,11 +2581,11 @@ static void gem_free_rx_buffers(struct macb *bp)
25812581
int i;
25822582

25832583
for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) {
2584-
if (!queue->rx_skbuff)
2584+
if (!queue->rx_buff)
25852585
continue;
25862586

25872587
for (i = 0; i < bp->rx_ring_size; i++) {
2588-
skb = queue->rx_skbuff[i];
2588+
skb = queue->rx_buff[i];
25892589

25902590
if (!skb)
25912591
continue;
@@ -2599,8 +2599,8 @@ static void gem_free_rx_buffers(struct macb *bp)
25992599
skb = NULL;
26002600
}
26012601

2602-
kfree(queue->rx_skbuff);
2603-
queue->rx_skbuff = NULL;
2602+
kfree(queue->rx_buff);
2603+
queue->rx_buff = NULL;
26042604
}
26052605
}
26062606

@@ -2663,13 +2663,13 @@ static int gem_alloc_rx_buffers(struct macb *bp)
26632663

26642664
for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) {
26652665
size = bp->rx_ring_size * sizeof(struct sk_buff *);
2666-
queue->rx_skbuff = kzalloc(size, GFP_KERNEL);
2667-
if (!queue->rx_skbuff)
2666+
queue->rx_buff = kzalloc(size, GFP_KERNEL);
2667+
if (!queue->rx_buff)
26682668
return -ENOMEM;
26692669
else
26702670
netdev_dbg(bp->dev,
2671-
"Allocated %d RX struct sk_buff entries at %p\n",
2672-
bp->rx_ring_size, queue->rx_skbuff);
2671+
"Allocated %d RX buff entries at %p\n",
2672+
bp->rx_ring_size, queue->rx_buff);
26732673
}
26742674
return 0;
26752675
}

0 commit comments

Comments
 (0)