Commit c92621b
net: phy: broadcom: fix BCM54213PE per-PHY init never called
BCM54213PE (PHY_ID = 0x600d84a2) and BCM54210E share the same model ID
when masked by PHY_ID_MATCH_MODEL_MASK (0xfffffff0): both reduce to
0x600d84a0. The dispatch switch in bcm54xx_config_init() switches on
phydev->drv->phy_id & PHY_ID_MATCH_MODEL_MASK, so the separate
case PHY_ID_BCM54213PE: could never match — the expression always
evaluated to 0x600d84a0, not 0x600d84a2. bcm54213pe_config_init() was
silently never called; BCM54213PE instead fell through to the
BCM54210E path.
Replace the dead case label with an exact driver ID check inside the
BCM54210E case, which already handles the same model ID family.
Fixes: 1001c6f ("phy: broadcom: Add bcm54213pe configuration")
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>1 parent 394ae0d commit c92621b
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
501 | | - | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
502 | 508 | | |
503 | 509 | | |
504 | 510 | | |
505 | 511 | | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | 512 | | |
510 | 513 | | |
511 | 514 | | |
| |||
0 commit comments