Skip to content

Commit ddb1d29

Browse files
KonstaTpelwell
authored andcommitted
fixup! pcie-brcmstb: move the unilateral disable of CLKREQ# before link-up
* Fixes build with Clang. drivers/pci/controller/pcie-brcmstb.c:1595:3: error: variable 'clkreq_cntl' is uninitialized when used here [-Werror,-Wuninitialized] 1595 | clkreq_cntl |= PCIE_MISC_HARD_PCIE_HARD_DEBUG_CLKREQ_DEBUG_ENABLE_MASK; | ^~~~~~~~~~~ drivers/pci/controller/pcie-brcmstb.c:1578:17: note: initialize the variable 'clkreq_cntl' to silence this warning 1578 | u32 clkreq_cntl; | ^ | = 0 1 error generated.
1 parent be45659 commit ddb1d29

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pci/controller/pcie-brcmstb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1635,7 +1635,7 @@ static void brcm_config_clkreq(struct brcm_pcie *pcie)
16351635
{
16361636
static const char err_msg[] = "invalid 'brcm,clkreq-mode' DT string\n";
16371637
const char *mode = "default";
1638-
u32 clkreq_cntl;
1638+
u32 clkreq_cntl = 0;
16391639
int ret, tmp;
16401640

16411641
ret = of_property_read_string(pcie->np, "brcm,clkreq-mode", &mode);

0 commit comments

Comments
 (0)