usb: dwc2: only masquerade split-IN interrupt transfers

Some hub hardware does not differentiate pipe direction in the
non-periodic split handler, so transfers to the same endpoint index will
collide. A simple fix is to limit the non-periodic masquerade only to IN
transfers, which are also the most affected by interrupt latency.

A recurrence of #2024

Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>

Author: P33M

drivers/usb/dwc2/hcd.c

@@ -685,7 +685,8 @@ static void dwc2_hc_init(struct dwc2_hsotg *hsotg, struct dwc2_host_chan *chan)
 	 * Devices are none the wiser - the handshake tokens are the same.
 	 * The fakery is undone in dwc2_hc_n_intr().
 	 */
-	if (chan->do_split && chan->ep_type == USB_ENDPOINT_XFER_INT)
+	if (chan->ep_is_in && chan->do_split &&
+	    chan->ep_type == USB_ENDPOINT_XFER_INT)
 		chan->ep_type = USB_ENDPOINT_XFER_CONTROL;
 
 	hcchar |= chan->ep_type << HCCHAR_EPTYPE_SHIFT & HCCHAR_EPTYPE_MASK;