drm/vc4: tests: Patch up the vc4 kunit tests#6789
Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.15.yfrom Apr 15, 2025
Merged
drm/vc4: tests: Patch up the vc4 kunit tests#6789pelwell merged 1 commit intoraspberrypi:rpi-6.15.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-6.15.yfrom
Conversation
Commit [1] removed the dynamic allocation of drm_modeset_acquire_ctx structures, with clients expected to allocate them by other means, such as on the stack. This usage model works less well when tests are split into separate initialisation and run phases, because a ctx allocated on the stack in the init function will go out of scope and likely be overwritten by the run function(s). As kunit tests seem to be single threaded, make ctx static to avoid the issue. [1] commit 30188df ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()") Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Contributor
Author
|
FYI, @mripard. |
Contributor
|
That doesn't work either. kunit isn't single-threaded, and lockdep will complain about it. You really need to initialize the state and context in the test function itself, see torvalds/linux@7e0351a |
Contributor
Author
|
It's nice of you to finally respond. This was sufficient to pass the tests, but we can adopt the more complex fix in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit [1] removed the dynamic allocation of drm_modeset_acquire_ctx structures, with clients expected to allocate them by other means, such as on the stack. This usage model works less well when tests are split into separate initialisation and run phases, because a ctx allocated on the stack in the init function will go out of scope and likely be overwritten by the run function(s).
As kunit tests seem to be single threaded, make ctx static to avoid the issue.
[1] commit 30188df ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()")