Skip to content

PCI: quirks: work around VL805 firmware ASPM meddling #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
P33M merged 1 commit into from
Apr 15, 2025
Merged

PCI: quirks: work around VL805 firmware ASPM meddling #6790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions drivers/pci/quirks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6225,6 +6225,22 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x56b0, aspm_l1_acceptable_latency
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x56b1, aspm_l1_acceptable_latency);
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x56c0, aspm_l1_acceptable_latency);
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x56c1, aspm_l1_acceptable_latency);

/*
* VL805 firmware can report 0 in the L0s/L1 Acceptable Latency fields.
* This is shorter than its own exit latency so ASPM for the link partner
* never gets enabled (but firmware toggles EP L1/L0s enable internally).
* However, L0s is flaky so explicitly disable it.
*/
static void vl805_aspm_fixup(struct pci_dev *dev)
{
dev->devcap &= ~PCI_EXP_DEVCAP_L1;
/* Set to own exit latency + 1 */
dev->devcap |= FIELD_PREP(PCI_EXP_DEVCAP_L1, 5);
pci_disable_link_state(dev, PCIE_LINK_STATE_L0S);
pci_info(dev, "ASPM: VL805 fixup applied\n");
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_VIA, 0x3483, vl805_aspm_fixup);
#endif

#ifdef CONFIG_PCIE_DPC
Expand Down