Skip to content

hwmon: aht10: Fix AHT20 initialization #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 1 commit into from
Apr 22, 2025
Merged

hwmon: aht10: Fix AHT20 initialization #6803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions drivers/hwmon/aht10.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
#define AHT10_CMD_MEAS 0b10101100
#define AHT10_CMD_RST 0b10111010

#define AHT20_CMD_INIT 0b10111110

/*
* Flags in the answer byte/command
*/
Expand All @@ -59,6 +61,7 @@ MODULE_DEVICE_TABLE(i2c, aht10_id);

static const struct of_device_id aht10_of_id[] = {
{ .compatible = "aosong,aht10", },
{ .compatible = "aosong,aht20", },
{ }
};
MODULE_DEVICE_TABLE(of, aht10_of_id);
Expand Down Expand Up @@ -107,8 +110,13 @@ struct aht10_data {
*/
static int aht10_init(struct aht10_data *data)
{
const u8 cmd_init[] = {AHT10_CMD_INIT, AHT10_CAL_ENABLED | AHT10_MODE_CYC,
0x00};
u8 cmd_init[] = {AHT10_CMD_INIT, AHT10_CAL_ENABLED | AHT10_MODE_CYC, 0x00};

if (data->crc8) { /* AHT20 */
cmd_init[0] = AHT20_CMD_INIT;
cmd_init[1] = AHT10_CAL_ENABLED;
}

int res;
u8 status;
struct i2c_client *client = data->client;
Expand Down