Skip to content

Add DT controlled XTRIG control to imx296#6827

Merged
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
6by9:rpi-6.12.y-imx296
Apr 29, 2025
Merged

Add DT controlled XTRIG control to imx296#6827
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
6by9:rpi-6.12.y-imx296

Conversation

@6by9
Copy link
Copy Markdown
Contributor

@6by9 6by9 commented Apr 29, 2025

Copying our downstream patch for imx477 that allows configuration
of external synchronisation signals via DT, add the same to imx296.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
@6by9 6by9 force-pushed the rpi-6.12.y-imx296 branch from 22caff0 to 930f477 Compare April 29, 2025 14:55
@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented Apr 29, 2025

The code is arranged so that the DT overrides the module parameter, whether the trigger is being enabled or disabled, whereas the overlay only allows it to be enabled. Removing the =1 from the parameter declaration would allow it to be disabled as well.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
@6by9 6by9 force-pushed the rpi-6.12.y-imx296 branch from 930f477 to dcaf09a Compare April 29, 2025 14:57
@6by9
Copy link
Copy Markdown
Contributor Author

6by9 commented Apr 29, 2025

The code is arranged so that the DT overrides the module parameter, whether the trigger is being enabled or disabled, whereas the overlay only allows it to be enabled. Removing the =1 from the parameter declaration would allow it to be disabled as well.

Updated to drop the =1. I'd just copied it across from imx477 which has separate overrides for setting sink or source, with absence being disabled.

@pelwell pelwell merged commit 4198a8a into raspberrypi:rpi-6.12.y Apr 29, 2025
12 of 13 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Apr 30, 2025
See: raspberrypi/linux#6824

kernel: DT: arm: bcm2712: re-add mmio-hi ranges for pciex1
See: raspberrypi/linux#6825

kernel: Add DT controlled XTRIG control to imx296
See: raspberrypi/linux#6827

kernel: drm/v3d: Add job to pending list if the reset was skipped
See: raspberrypi/linux#6822

kernel: drivers: media: i2c: imx335: Fix frame size enumeration
See: raspberrypi/linux#6829
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Apr 30, 2025
See: raspberrypi/linux#6824

kernel: DT: arm: bcm2712: re-add mmio-hi ranges for pciex1
See: raspberrypi/linux#6825

kernel: Add DT controlled XTRIG control to imx296
See: raspberrypi/linux#6827

kernel: drm/v3d: Add job to pending list if the reset was skipped
See: raspberrypi/linux#6822

kernel: drivers: media: i2c: imx335: Fix frame size enumeration
See: raspberrypi/linux#6829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants