usb: xhci: set Input Slot Context bit in xhci_fixup_endpoint#6850
Merged
Conversation
The Renesas uPD controller is a bit more picky about validating Configure Endpoint TRBs and requires that bit 0 of the ADD field is 1. This is mentioned in xhci v1.2 s4.6.6. Also drop a redundant helper function and reject invalid endpoints. Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 21, 2025
kernel: usb: xhci: set Input Slot Context bit in xhci_fixup_endpoint See: raspberrypi/linux#6850 kernel: configs: Enable more MediaTek drivers See: raspberrypi/linux#6857 kernel: firmware/raspberrypi: raise timeout to 3s See: raspberrypi/linux#6859 kernel: overlays: sc16is75x: Disable spidev0 first See: raspberrypi/linux#6858 kernel: gpiolib: Avoid the hotplug performance reduction See: raspberrypi/linux#6862
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 21, 2025
kernel: usb: xhci: set Input Slot Context bit in xhci_fixup_endpoint See: raspberrypi/linux#6850 kernel: configs: Enable more MediaTek drivers See: raspberrypi/linux#6857 kernel: firmware/raspberrypi: raise timeout to 3s See: raspberrypi/linux#6859 kernel: overlays: sc16is75x: Disable spidev0 first See: raspberrypi/linux#6858 kernel: gpiolib: Avoid the hotplug performance reduction See: raspberrypi/linux#6862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perils of open-coding TRB fields: missed a bit.
The Renesas uPD controller no longer barfs when adjusting a keyboard/mouse polling intervals. RP1 and VL805 remain unbothered.