Skip to content

Fix up rp1_dpi_pio for CONFIG_RP1_PIO=n builds #6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njhollinghurst merged 2 commits into from
May 13, 2025
+3 −2
Merged

Fix up rp1_dpi_pio for CONFIG_RP1_PIO=n builds #6851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b85641
Revert "drm/rp1/rp1_dsi: Move Composite Sync generation into the kernel"
pelwell May 13, 2025
68fc517
drm/rp1/rp1_dpi: Move Composite Sync generation into the kernel
njhollinghurst Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions drivers/gpu/drm/rp1/rp1-dpi/rp1_dpi_pio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,9 +596,10 @@ void rp1dpi_pio_stop(struct rp1_dpi *dpi)

#else /* !IS_REACHABLE(CONFIG_RP1_PIO) */

int rp1dpi_pio_start(struct rp1_dpi *dpi, const struct drm_display_mode *mode)
int rp1dpi_pio_start(struct rp1_dpi *dpi, const struct drm_display_mode *mode,
bool force_csync)
{
if (mode->flags & (DRM_MODE_FLAG_CSYNC | DRM_MODE_FLAG_INTERLACE)) {
if (mode->flags & (DRM_MODE_FLAG_CSYNC | DRM_MODE_FLAG_INTERLACE) || force_csync) {
drm_warn(&dpi->drm, "DPI needs PIO support for Interlace or CSync\n");
return -ENODEV;
} else {
Expand Down