brcmfmac: Add power_save_disable module parameter#7038
Closed
pelwell wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Closed
brcmfmac: Add power_save_disable module parameter#7038pelwell wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
pelwell wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
The power_save_disable module parameter allows power management to be
disabled from start of day, e.g. from a .conf file, without needing to
run any commands from e.g. a systemd service. It also prevents any
subsequent modifications unless the parameter is changed at runtime.
N.B. With power management disabled in this way, commands such as
"iw wlan0 get power_save" may indicated that it is enabled, but the
output in the kernel log says otherwise:
brcmfmac: brcmf_cfg80211_set_power_mgmt: power save disabled
See: RPi-Distro/raspi-config#282
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Collaborator
|
Is this preferable to NetworkManager config option An option that disables power-save but incorrectly reports it is enabled may cause confusion. |
Contributor
Author
|
I was humouring @XECDesign, but with that config option that everyone's talking about this is unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The power_save_disable module parameter allows power management to be disabled from start of day, e.g. from a .conf file, without needing to run any commands from e.g. a systemd service. It also prevents any subsequent modifications unless the parameter is changed at runtime.
N.B. With power management disabled in this way, commands such as "iw wlan0 get power_save" may indicated that it is enabled, but the output in the kernel log says otherwise:
See: RPi-Distro/raspi-config#282