Skip to content

staging: vc04_services: vchiq-mmal: validate component index in event_to_host_cb() #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 1 commit into from
Apr 21, 2026
+9 −2
Merged

staging: vc04_services: vchiq-mmal: validate component index in event_to_host_cb() #7327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,12 +478,19 @@ static void event_to_host_cb(struct vchiq_mmal_instance *instance,
struct mmal_msg *msg, u32 msg_len)
{
int comp_idx = msg->u.event_to_host.client_component;
struct vchiq_mmal_component *component =
&instance->component[comp_idx];
struct vchiq_mmal_component *component;
struct vchiq_mmal_port *port = NULL;
struct mmal_msg_context *msg_context;
u32 port_num = msg->u.event_to_host.port_num;

if (comp_idx < 0 || comp_idx >= VCHIQ_MMAL_MAX_COMPONENTS) {
pr_err_ratelimited("%s: component index %d out of range\n",
__func__, comp_idx);
return;
}

component = &instance->component[comp_idx];

if (msg->u.buffer_from_host.drvbuf.magic == MMAL_MAGIC) {
pr_err("%s: MMAL_MSG_TYPE_BUFFER_TO_HOST with bad magic\n",
__func__);
Expand Down
Loading