Skip to content

Fix some NV12 and NV21 format related issues #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidplowman merged 1 commit into from
Jul 1, 2026
+13 −4
Merged

Fix some NV12 and NV21 format related issues #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion picamera2/encoders/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,14 @@ def send_streams(self, output):

def _send_streams(self, output):
# Send video stream information to the output.
FORMAT_TABLE = {"YUV420": "yuv420p", "BGR888": "rgb24", "RGB888": "bgr24", "XBGR8888": "rgba", "XRGB8888": "bgra"}
FORMAT_TABLE = {
"YUV420": "yuv420p",
"BGR888": "rgb24",
"RGB888": "bgr24",
"XBGR8888": "rgba",
"XRGB8888": "bgra",
"NV12": "nv12",
}
pix_fmt = FORMAT_TABLE.get(self._format)
rate = Fraction(1000000, self._framerate)
if pix_fmt is None and output.needs_add_stream:
Expand Down
8 changes: 5 additions & 3 deletions picamera2/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,13 @@ def save(
V = reshaped[2 * height + height // 2 :, : width // 2]
output_bytes = simplejpeg.encode_jpeg_yuv_planes(Y, U, V, quality)
Y = reshaped = U = V = None
elif format == 'NV12':
elif format in ('NV12', 'NV21'):
width, height = self.config[name]['size']
Y = m.array[:height, :width]
U = np.ascontiguousarray(m.array[height : height + height // 2, 0 : 2 * width : 2])
V = np.ascontiguousarray(m.array[height : height + height // 2, 1 : 2 * width : 2])
if format == 'NV21':
U, V = V, U
output_bytes = simplejpeg.encode_jpeg_yuv_planes(Y, U, V, quality)
Y = U = V = None
else:
Expand Down Expand Up @@ -333,10 +335,10 @@ def _make_array_shared(self, buffer: np.ndarray, config: Dict[str, Any]) -> np.n
# These dimensions seem a bit strange, but mean that
# cv2.cvtColor(image, cv2.COLOR_YUV2BGR_YUYV) will convert directly to RGB.
image = array.reshape(h, stride // 2, 2)
elif fmt == "NV12":
elif fmt in ("NV12", "NV21"):
# The UV rows should be as long as the Y rows, so we can slice off any
# padding.
image = array.reshape((h * 3 // 2, stride))[:w]
image = array.reshape((h * 3 // 2, stride))[:, :w]
elif fmt == "MJPEG":
image = np.array(Image.open(io.BytesIO(array))) # type: ignore
elif formats.is_raw(fmt):
Expand Down
Loading