Add reset interface to multi CDC example#694
Open
will-v-pi wants to merge 6 commits into
Open
Conversation
|
This allows picotool to put the board in BOOTSEL mode, but the serial numbers of the example and the bootloader don't match so picotool can't find it. |
lurch
reviewed
May 20, 2026
lurch
reviewed
May 20, 2026
kilograham
reviewed
Jun 1, 2026
|
|
||
| // TinyUSB device task must be called regularly, so we use a repeating timer | ||
| struct repeating_timer timer; | ||
| add_repeating_timer_ms(1, tud_task_callback, NULL, &timer); |
Contributor
There was a problem hiding this comment.
This seems like a bad idea - there is no locking on the called tud_task(), so may interfere with the tasks in the loop below - perhaps the example should just use the task from the loop as before, but do something less silly (i.e. use a state machine rather than a sleep) in custom_cdc_task() - not really sure that custom_cdc_task is very interesting as is anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on raspberrypi/pico-sdk#2629 which has now been merged
This adds a reset interface to the
dev_multi_cdcexample, along with other improvements to the responsiveness and structure