Small test fixups#2942
Open
will-v-pi wants to merge 5 commits into
Open
Conversation
Without this, the PASSED string is sometimes not printed
peterharperuk
previously approved these changes
May 15, 2026
lurch
reviewed
May 15, 2026
Contributor
|
IIRC (when I was looking at one of Graham's PRs) there are also some tests that call Ahh, see my comment here #2897 (comment) |
Contributor
Author
Those tests don't use |
peterharperuk
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests with stdio_usb need the final output to be flushed before exiting (which is done by
stdio_deinit_all), otherwise they don't always printPASSEDhardware_sync_spin_lock_testtakes too long on RP2040, so increase the timeout as it was close to timing out on RP2350 anyway