Skip to content

RP2350 bootrom rom_reboot() does not actually reboot for delay_ms of 0 so call it with 1 instead #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilograham merged 1 commit into from
Jun 19, 2026
+4 −0
Merged

RP2350 bootrom rom_reboot() does not actually reboot for delay_ms of 0 so call it with 1 instead #3018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/rp2_common/pico_bootrom/include/pico/bootrom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,10 @@ static inline int rom_set_bootrom_stack(bootrom_stack_t *stack) {
* \param p1 parameter 1, depends on flags
*/
static inline int rom_reboot(uint32_t flags, uint32_t delay_ms, uint32_t p0, uint32_t p1) {
#if PICO_RP2350
// work around bootrom bug with 0 timeout
if (!delay_ms) delay_ms = 1;
#endif
rom_reboot_fn func = (rom_reboot_fn) rom_func_lookup_inline(ROM_FUNC_REBOOT);
return func(flags, delay_ms, p0, p1);
}
Expand Down
Loading