remove EXEC2 (#304)

Author: kilograham

picoboot_connection/picoboot_connection.c

@@ -454,19 +454,6 @@ int picoboot_exec(libusb_device_handle *usb_device, uint32_t addr) {
     return picoboot_cmd(usb_device, &cmd, NULL, 0);
 }
 
-// int picoboot_exec2(libusb_device_handle *usb_device, struct picoboot_exec2_cmd *exec2_cmd) {
-//     struct picoboot_cmd cmd;
-//     // shouldn't be necessary any more
-//     // addr |= 1u; // Thumb bit
-//     //if (verbose) output("EXEC2 %08x\n", (unsigned int) exec2_cmd->scan_base);
-//     cmd.bCmdId = PC_EXEC2;
-//     cmd.bCmdSize = sizeof(cmd.exec2_cmd);
-//     cmd.dTransferLength = 0;
-//     cmd.exec2_cmd = *exec2_cmd;
-//     return picoboot_cmd(usb_device, &cmd, NULL, 0);
-// } // currently unused
-
-
 int picoboot_flash_erase(libusb_device_handle *usb_device, uint32_t addr, uint32_t len) {
     struct picoboot_cmd cmd;
     if (verbose) output("FLASH_ERASE %08x+%08x\n", (unsigned int) addr, (unsigned int) len);

picoboot_connection/picoboot_connection.h

@@ -56,7 +56,6 @@ int picoboot_reboot(libusb_device_handle *usb_device, uint32_t pc, uint32_t sp,
 int picoboot_reboot2(libusb_device_handle *usb_device, struct picoboot_reboot2_cmd *reboot_cmd);
 int picoboot_get_info(libusb_device_handle *usb_device, struct picoboot_get_info_cmd *cmd, uint8_t *buffer, uint32_t len);
 int picoboot_exec(libusb_device_handle *usb_device, uint32_t addr);
-// int picoboot_exec2(libusb_device_handle *usb_device, struct picoboot_exec2_cmd *exec2_cmd); // currently unused
 int picoboot_flash_erase(libusb_device_handle *usb_device, uint32_t addr, uint32_t len);
 int picoboot_vector(libusb_device_handle *usb_device, uint32_t addr);
 int picoboot_write(libusb_device_handle *usb_device, uint32_t addr, uint8_t *buffer, uint32_t len);

picoboot_connection/picoboot_connection_cxx.cpp

@@ -108,10 +108,6 @@ void connection::exec(uint32_t addr) {
     wrap_call([&] { return picoboot_exec(device, addr); });
 }
 
-// void connection::exec2(struct picoboot_exec2_cmd *cmd) {
-//     wrap_call([&] { return picoboot_exec2(device, cmd); });
-// } // currently unused
-
 void connection::flash_erase(uint32_t addr, uint32_t len) {
     wrap_call([&] { return picoboot_flash_erase(device, addr, len); });
 }

picoboot_connection/picoboot_connection_cxx.h

@@ -47,7 +47,6 @@ namespace picoboot {
         void reboot(uint32_t pc, uint32_t sp, uint32_t delay_ms);
         void reboot2(struct picoboot_reboot2_cmd *cmd);
         void exec(uint32_t addr);
-        // void exec2(struct picoboot_exec2_cmd *cmd); // currently unused
         void get_info(struct picoboot_get_info_cmd *get_info_cmd, uint8_t *buffer, uint32_t len);
         void flash_erase(uint32_t addr, uint32_t len);
         void vector(uint32_t addr);