Skip to content

Add make-boot-image service#11

Draft
roliver-rpi wants to merge 1 commit into
raspberrypi:mainfrom
roliver-rpi:make-boot-image
Draft

Add make-boot-image service#11
roliver-rpi wants to merge 1 commit into
raspberrypi:mainfrom
roliver-rpi:make-boot-image

Conversation

@roliver-rpi
Copy link
Copy Markdown
Collaborator

No description provided.

@roliver-rpi
Copy link
Copy Markdown
Collaborator Author

Hi @XECDesign , would it be possible to get some feedback on this packaging approach? This service aims to create replacement images for linux-image--2712 packages that include the kernel directly into a signed ramdisk. I suspect I'll probably need a replacement linux-image-rpi-2712 meta-package too?

@XECDesign
Copy link
Copy Markdown

Sorry, afraid I can't be of much help here.

Copy link
Copy Markdown
Collaborator

@tdewey-rpi tdewey-rpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with the approach, but your point on systemd service restarting is taken.

We do, however, need it to support 2711 first - as CM4 is a commercially available platform, and there are no 2712 platforms where we actively support secure boot at this time.

Comment thread make-boot-image/README.md Outdated
Comment thread make-boot-image/make-boot-image-from-kernel Outdated
Signed-off-by: Richard Oliver <richard.oliver@raspberrypi.com>
@roliver-rpi
Copy link
Copy Markdown
Collaborator Author

Updated documentation, validator.py, inserted preinst script to remove /boot/firmware/config.txt

This will have to be parked for-now as the cryptroot initramfs is unable to insmod the compressed .ko.xz modules. We can revisit this once the cryptroot image has been updated.

Comment thread README.adoc

A display name and email address in RFC 5322 mailbox format of the individual /
team responsible for creating your boot-image packages. e.g.
`Packaging Team <packaging-team@example.com>'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent formatting - maybe get this through a asciidoc preview tool?

Comment thread config/validator.py
@@ -1,5 +1,6 @@
## Format of return will be [Happy: bool, error: str]
from os import path
from email.utils import parseaddr, formataddr
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a core dep, or does it require an additional package?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the Python standard library. It's provided by libpython3-stdlib in Debian, but this is a hard-dep of the python3 package. Even if we were to use python3-minimal, we would still get email.utils as part of libpython3.11-minimal

Comment thread make-boot-image/README.md
> [!CAUTION]
> Support only exists for v8 kernels at this time.

## Configuration
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be expanded to include the vendor fields?

rpi-package-download@"$(systemd-escape "${1}")".service
}

KERNEL_2711="linux-image-${LINUX_IMAGE}"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the run-around, but I would prefer this was named 'kernel_v8' or similar. Not a blocker.

@tdewey-rpi
Copy link
Copy Markdown
Collaborator

@roliver-rpi Is this ready to review in earnest?

@roliver-rpi
Copy link
Copy Markdown
Collaborator Author

@roliver-rpi Is this ready to review in earnest?

No, the current cryptroot initramfs is unable to insmod the compressed .ko.xz modules that we take from the linux-image package. This should be parked until we update the cryptroot initramfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants