Refactor new_gt function: simplify implementation by directly returning new_lt with reason parameter.

riccardodebenedictis · riccardodebenedictis · commit 38f396ec4dd6 · 2025-11-13T11:39:50.000+01:00
diff --git a/src/linspire.cpp b/src/linspire.cpp
@@ -117,13 +117,7 @@ namespace linspire
             return reason ? set_ub(slack, c_right, reason.value()) : set_ub(slack, c_right); // we are in the case `expr < c_right`..
         }
     }
-    bool solver::new_gt(const utils::lin &lhs, const utils::lin &rhs, bool strict, std::optional<std::reference_wrapper<constraint>> reason) noexcept
-    {
-        if (reason)
-            return new_lt(rhs, lhs, strict, *reason);
-        else
-            return new_lt(rhs, lhs, strict);
-    }
+    bool solver::new_gt(const utils::lin &lhs, const utils::lin &rhs, bool strict, std::optional<std::reference_wrapper<constraint>> reason) noexcept { return new_lt(rhs, lhs, strict, reason); }
 
     void solver::retract(constraint &c) noexcept
     {

Original file line number	Diff line number	Diff line change
`@@ -117,13 +117,7 @@ namespace linspire`
`117`	`117`	return reason ? set_ub(slack, c_right, reason.value()) : set_ub(slack, c_right); // we are in the case `expr < c_right`..
`118`	`118`	`}`
`119`	`119`	`}`
`120`		`- bool solver::new_gt(const utils::lin &lhs, const utils::lin &rhs, bool strict, std::optional<std::reference_wrapper<constraint>> reason) noexcept`
`121`		`- {`
`122`		`- if (reason)`
`123`		`- return new_lt(rhs, lhs, strict, *reason);`
`124`		`- else`
`125`		`- return new_lt(rhs, lhs, strict);`
`126`		`- }`
	`120`	`+ bool solver::new_gt(const utils::lin &lhs, const utils::lin &rhs, bool strict, std::optional<std::reference_wrapper<constraint>> reason) noexcept { return new_lt(rhs, lhs, strict, reason); }`
`127`	`121`
`128`	`122`	`void solver::retract(constraint &c) noexcept`
`129`	`123`	`{`