Refactor var class constructor: remove id parameter and adjust implementation for improved clarity and consistency

Author: riccardodebenedictis

include/var.hpp

@@ -15,7 +15,7 @@ namespace linspire
     friend class solver;
 
   public:
-    var(const utils::var id, const utils::inf_rational &lb = utils::inf_rational(utils::rational::negative_infinite), const utils::inf_rational &ub = utils::inf_rational(utils::rational::positive_infinite)) noexcept;
+    var(const utils::inf_rational &lb = utils::inf_rational(utils::rational::negative_infinite), const utils::inf_rational &ub = utils::inf_rational(utils::rational::positive_infinite)) noexcept;
 
     [[nodiscard]] utils::inf_rational get_lb() const noexcept;
     [[nodiscard]] utils::inf_rational get_ub() const noexcept;
@@ -31,7 +31,6 @@ namespace linspire
     void unset_ub(const utils::inf_rational &v, std::shared_ptr<const constraint> reason) noexcept;
 
   private:
-    const utils::var id;                                                                 // the id of this variable in the solver..
     std::map<utils::inf_rational, std::set<std::shared_ptr<const constraint>>> lbs, ubs; // the lower and upper bounds with their reasons..
     utils::inf_rational val;                                                             // the current value of this variable..
   };

src/linspire.cpp

@@ -9,7 +9,7 @@ namespace linspire
     {
         assert(lb <= ub);
         const auto x = vars.size();
-        vars.emplace_back(x, lb, ub);
+        vars.emplace_back(lb, ub);
         t_watches.emplace_back();
         return x;
     }

src/var.cpp

@@ -4,7 +4,7 @@
 
 namespace linspire
 {
-    var::var(const utils::var id, const utils::inf_rational &lb, const utils::inf_rational &ub) noexcept : id(id) { assert(lb < ub); }
+    var::var(const utils::inf_rational &lb, const utils::inf_rational &ub) noexcept { assert(lb < ub); }
 
     utils::inf_rational var::get_lb() const noexcept { return lbs.empty() ? utils::rational::negative_infinite : lbs.rbegin()->first; }
     utils::inf_rational var::get_ub() const noexcept { return ubs.empty() ? utils::rational::positive_infinite : ubs.begin()->first; }