Skip to content

RDBC-1081 Add TimeSeriesDeletedRanges, MaxReadOpsPerSecond and SkipCorruptedData to smuggler options#563

Merged
M4xymm merged 1 commit into
ravendb:v7.2from
M4xymm:RDBC-1081-2
Jul 10, 2026
Merged

RDBC-1081 Add TimeSeriesDeletedRanges, MaxReadOpsPerSecond and SkipCorruptedData to smuggler options#563
M4xymm merged 1 commit into
ravendb:v7.2from
M4xymm:RDBC-1081-2

Conversation

@M4xymm

@M4xymm M4xymm commented Jul 10, 2026

Copy link
Copy Markdown
Member

Issue link

https://issues.hibernatingrhinos.com/issue/RDBC-1081

Additional description

  • Add TimeSeriesDeletedRanges to DatabaseItemType and DEFAULT_OPERATE_ON_TYPES
  • Add maxReadOpsPerSecond to DatabaseSmugglerOptions and its interface
  • Add skipCorruptedData to IDatabaseSmugglerOptions interface

Type of change

  • Bug fix
  • Regression bug fix
  • Optimization
  • New feature

How risky is the change?

  • Low
  • Moderate
  • High
  • Not relevant

Backward compatibility

  • Non breaking change
  • Ensured. Please explain how has it been implemented?
  • Breaking change
  • Not relevant

Is it platform specific issue?

  • Yes. Please list the affected platforms.
  • No

Documentation update

  • This change requires a documentation update. Please mark the issue on YouTrack using Documentation Required tag.
  • No documentation update is needed

Testing by Contributor

  • Tests have been added that prove the fix is effective or that the feature works
  • Internal classes added to the test class (e.g. entity or index definition classes) have the lowest possible access modifier (preferable private)
  • It has been verified by manual testing
  • Existing tests verify the correct behavior

Testing by RavenDB QA team

  • This change requires a special QA testing due to possible performance or resources usage implications (CPU, memory, IO). Please mark the issue on YouTrack using QA Required tag.
  • No special testing by RavenDB QA team is needed

Is there any existing behavior change of other features due to this change?

  • Yes. Please list the affected features/subsystems and provide appropriate explanation
  • No

UI work

  • It requires further work in the Studio. Please mark the issue on YouTrack using Studio Required tag.
  • No UI work is needed

…rruptedData to smuggler options

- Add TimeSeriesDeletedRanges to DatabaseItemType and DEFAULT_OPERATE_ON_TYPES
- Add maxReadOpsPerSecond to DatabaseSmugglerOptions and its interface
- Add skipCorruptedData to IDatabaseSmugglerOptions interface
@M4xymm
M4xymm requested a review from kalczur July 10, 2026 07:01
}
});

it("can export and import with maxReadOpsPerSecond, skipCorruptedData and timeSeriesDeletedRanges", async () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] TimeSeriesDeletedRanges is never exercised.
SmugglerTest.ts (line 82) only checks that the default array contains the value. It never deletes a time-series range, and the destination assertion only checks document count. The test would pass even if deleted ranges were not exported or imported. Create a deletion and assert GetDetailedStatisticsOperation().countOfTimeSeriesDeletedRanges after import.

[P2] The new options are not observably tested.
SmugglerTest.ts (line 91) uses a healthy three-document database, so the test remains green if both fields disappear from the request. Add request serialization assertions for MaxReadOpsPerSecond and SkipCorruptedData. Also remove skipCorruptedData from the import options at line 108: it is documented as export-corruption recovery behavior.

@M4xymm
M4xymm merged commit d6e5c23 into ravendb:v7.2 Jul 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants