RDBC-1081 Add TimeSeriesDeletedRanges, MaxReadOpsPerSecond and SkipCorruptedData to smuggler options#563
Conversation
…rruptedData to smuggler options - Add TimeSeriesDeletedRanges to DatabaseItemType and DEFAULT_OPERATE_ON_TYPES - Add maxReadOpsPerSecond to DatabaseSmugglerOptions and its interface - Add skipCorruptedData to IDatabaseSmugglerOptions interface
| } | ||
| }); | ||
|
|
||
| it("can export and import with maxReadOpsPerSecond, skipCorruptedData and timeSeriesDeletedRanges", async () => { |
There was a problem hiding this comment.
[P2] TimeSeriesDeletedRanges is never exercised.
SmugglerTest.ts (line 82) only checks that the default array contains the value. It never deletes a time-series range, and the destination assertion only checks document count. The test would pass even if deleted ranges were not exported or imported. Create a deletion and assert GetDetailedStatisticsOperation().countOfTimeSeriesDeletedRanges after import.
[P2] The new options are not observably tested.
SmugglerTest.ts (line 91) uses a healthy three-document database, so the test remains green if both fields disappear from the request. Add request serialization assertions for MaxReadOpsPerSecond and SkipCorruptedData. Also remove skipCorruptedData from the import options at line 108: it is documented as export-corruption recovery behavior.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1081
Additional description
Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.