Skip to content

Commit 46ad41e

Browse files
committed
RDBC-1035 Rename aggressive cache context
1 parent cf4734b commit 46ad41e

2 files changed

Lines changed: 12 additions & 10 deletions

File tree

ravendb/documents/store/definition.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444

4545
if TYPE_CHECKING:
4646
from ravendb.documents.indexes.abstract_index_creation_tasks import AbstractIndexCreationTask
47+
from ravendb.http.misc import AggressiveCacheMode, AggressiveCacheOptions
4748

4849

4950
class DocumentStoreBase:
@@ -560,7 +561,7 @@ def aggressively_cache_for(
560561
cache_duration: datetime.timedelta,
561562
database: Optional[str] = None,
562563
mode: Optional["AggressiveCacheMode"] = None,
563-
) -> "DocumentStore._DisableAggressiveCachingContext":
564+
) -> "DocumentStore._AggressiveCacheOverrideScope":
564565
from ravendb.http.misc import AggressiveCacheMode
565566

566567
if mode is None:
@@ -573,21 +574,21 @@ def _set_aggressive_cache(
573574
cache_duration: datetime.timedelta,
574575
mode: "AggressiveCacheMode",
575576
database: Optional[str] = None,
576-
) -> "DocumentStore._DisableAggressiveCachingContext":
577+
) -> "DocumentStore._AggressiveCacheOverrideScope":
577578
from ravendb.http.misc import AggressiveCacheOptions
578579

579580
self.assert_initialized()
580581
database = self.get_effective_database(database)
581582
request_executor = self.get_request_executor(database)
582583
options = AggressiveCacheOptions(cache_duration, mode)
583-
return DocumentStore._DisableAggressiveCachingContext(request_executor, options)
584+
return DocumentStore._AggressiveCacheOverrideScope(request_executor, options)
584585

585586
def _finalize_aggressive_cache(
586587
self,
587-
context: "DocumentStore._DisableAggressiveCachingContext",
588+
context: "DocumentStore._AggressiveCacheOverrideScope",
588589
mode: "AggressiveCacheMode",
589590
database: Optional[str] = None,
590-
) -> "DocumentStore._DisableAggressiveCachingContext":
591+
) -> "DocumentStore._AggressiveCacheOverrideScope":
591592
from ravendb.http.misc import AggressiveCacheMode
592593

593594
try:
@@ -614,17 +615,17 @@ def _listen_to_changes_and_update_cache(self, database: str) -> None:
614615

615616
def disable_aggressive_caching(
616617
self, database: Optional[str] = None
617-
) -> "DocumentStore._DisableAggressiveCachingContext":
618+
) -> "DocumentStore._AggressiveCacheOverrideScope":
618619
self.assert_initialized()
619620
database = self.get_effective_database(database)
620621
request_executor = self.get_request_executor(database)
621-
return DocumentStore._DisableAggressiveCachingContext(request_executor)
622+
return DocumentStore._AggressiveCacheOverrideScope(request_executor)
622623

623-
class _DisableAggressiveCachingContext:
624-
def __init__(self, request_executor, options=None):
624+
class _AggressiveCacheOverrideScope:
625+
def __init__(self, request_executor: RequestExecutor, options: AggressiveCacheOptions = None):
625626
self._request_executor = request_executor
626627
self._options = options
627-
self._old_options = None
628+
self._old_options: Optional[AggressiveCacheOptions] = None
628629

629630
def __enter__(self):
630631
self._old_options = self._request_executor.aggressive_caching

ravendb/http/request_executor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
LoadBalanceBehavior,
3535
Broadcast,
3636
AggressiveCacheMode,
37+
AggressiveCacheOptions,
3738
)
3839
from ravendb.http.raven_command import RavenCommand, RavenCommandResponseType
3940
from ravendb.http.server_node import ServerNode

0 commit comments

Comments
 (0)