Fix exception-dispatcher tests; expect RavenException / message-contains

The client ExceptionDispatcher only ever yields RavenException (or a mapped
subclass) and appends a status-code suffix to the message, so tests asserting
bare exceptions.* types or exact messages could never pass. Per the csharp-sync
testing rule, server-side errors use assertRaisesWithMessageContaining.

- test_cannot_create_database_with_the_same_name: unskip; assertRaises(RavenException) on duplicate create.
- test_update_by_index_fail / test_delete_by_index_fail: unskip; expect RavenException.
- test_put_fail: unskip; expect RavenException for an invalid (non-object) document body.
- test_can_replace_certificate: unskip; assertRaisesWithMessage -> assertRaisesWithMessageContaining.
- test_ravenDB_13456 (identity-parts-separator): skip -> skipIf(RAVENDB_LICENSE); message asserts -> contains.
- test_time_series_configuration: drop "Disable on pull request" skips on the 3 configure tests; _3 message asserts -> contains.

Also fix TimeSeriesCollectionConfiguration.to_json to guard None policies/raw_policy
(Python defaults them to None, unlike C#), which crashed test_can_configure_time_series.

Author: poissoncorp

ravendb/documents/operations/time_series.py

@@ -101,8 +101,8 @@ def from_json(cls, json_dict: Dict[str, Any]) -> TimeSeriesCollectionConfigurati
     def to_json(self) -> Dict[str, Any]:
         return {
             "Disabled": self.disabled,
-            "Policies": [policy.to_json() for policy in self.policies],
-            "RawPolicy": self.raw_policy.to_json(),
+            "Policies": [policy.to_json() for policy in (self.policies or [])],
+            "RawPolicy": self.raw_policy.to_json() if self.raw_policy is not None else None,
         }
 
 

ravendb/tests/jvm_migrated_tests/client_tests/time_series_tests/test_time_series_configuration.py

@@ -38,7 +38,6 @@ def test_deserialization(self):
         self.assertEqual(TimeValueUnit.NONE, time_value.unit)
         self.assertEqual(0, time_value.value)
 
-    @unittest.skip("Disable on pull request")
     def test_can_configure_time_series(self):
         config = TimeSeriesConfiguration()
         self.store.maintenance.send(ConfigureTimeSeriesOperation(config))
@@ -90,7 +89,6 @@ def test_can_configure_time_series(self):
         self.assertEqual(TimeValue.of_years(3), policies[5].retention_time)
         self.assertEqual(TimeValue.of_years(1), policies[5].aggregation_time)
 
-    @unittest.skip("Disable on pull request")
     def test_can_configure_time_series_2(self):
         collection_name = "Users"
 
@@ -206,7 +204,6 @@ def test_not_valid_configure_should_throw(self):
             ConfigureTimeSeriesOperation(config3),
         )
 
-    @unittest.skip("Disable on pull request")
     def test_configure_time_series_3(self):
         self.store.time_series.set_policy(
             User, "By15SecondsFor1Minute", TimeValue.of_seconds(15), TimeValue.of_seconds(60)
@@ -245,7 +242,7 @@ def test_configure_time_series_3(self):
         self.assertEqual(TimeValue.of_years(3), policies[5].retention_time)
         self.assertEqual(TimeValue.of_years(1), policies[5].aggregation_time)
 
-        self.assertRaisesWithMessage(
+        self.assertRaisesWithMessageContaining(
             self.store.time_series.remove_policy,
             Exception,
             "The policy 'By15SecondsFor1Minute' has a retention time of '60 seconds' "
@@ -254,7 +251,7 @@ def test_configure_time_series_3(self):
             "ByMinuteFor3Hours",
         )
 
-        self.assertRaisesWithMessage(
+        self.assertRaisesWithMessageContaining(
             self.store.time_series.set_raw_policy,
             Exception,
             "The policy 'rawpolicy' has a retention time of '10 seconds' but should be aggregated by policy "

ravendb/tests/jvm_migrated_tests/https_tests/test_https.py

@@ -35,10 +35,9 @@ def test_can_connect_with_certificate(self):
                 session.store(user, "users/1")
                 session.save_changes()
 
-    @unittest.skip("Exception dispatcher")
     def test_can_replace_certificate(self):
         with self.secured_document_store as sec_store:
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 sec_store.maintenance.server.send,
                 Exception,
                 "Unable to load the provided certificate",

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_13456.py

@@ -1,3 +1,4 @@
+import os
 import unittest
 
 from ravendb.documents.operations.configuration.definitions import ClientConfiguration
@@ -12,7 +13,7 @@ class TestRavenDB13456(TestBase):
     def setUp(self):
         super().setUp()
 
-    @unittest.skip("Fails on cicd due to free license - adding the client configuration is disallowed")
+    @unittest.skipIf(os.environ.get("RAVENDB_LICENSE") is None, "Insufficient license permissions. Skipping on CI/CD.")
     def test_can_change_identity_parts_separator(self):
         with self.store.open_session() as session:
             company1 = Company()
@@ -44,15 +45,15 @@ def test_can_change_identity_parts_separator(self):
 
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company|", Company())
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company| cannot end with '|' or '/' as part of cluster transaction",
             )
 
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company/", Company())
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company/ cannot end with '|' or '/' as part of cluster transaction",
@@ -90,7 +91,7 @@ def test_can_change_identity_parts_separator(self):
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company:", Company())
 
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company: cannot end with '|' or ':' as part of cluster transaction",
@@ -99,7 +100,7 @@ def test_can_change_identity_parts_separator(self):
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company|", Company())
 
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company| cannot end with '|' or ':' as part of cluster transaction",
@@ -148,15 +149,15 @@ def test_can_change_identity_parts_separator(self):
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company|", Company())
 
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company| cannot end with '|' or '/' as part of cluster transaction",
             )
 
         with self.store.open_session(session_options=session_options) as session:
             session.advanced.cluster_transaction.create_compare_exchange_value("company/", Company())
-            self.assertRaisesWithMessage(
+            self.assertRaisesWithMessageContaining(
                 session.save_changes,
                 RuntimeError,  # todo: change to RavenException when the Exception Dispatcher will be ready
                 "Document id company/ cannot end with '|' or '/' as part of cluster transaction",

ravendb/tests/operations_tests/test_server_operations.py

@@ -1,4 +1,5 @@
 from ravendb.serverwide.operations.common import GetDatabaseNamesOperation
+from ravendb.exceptions.raven_exceptions import RavenException
 from ravendb.tests.test_base import *
 import unittest
 
@@ -21,13 +22,13 @@ def test_create_database_name_longer_than_260_chars(self):
             except Exception as exception:
                 raise exception
 
-    @unittest.skip("Exception dispatcher")
     def test_cannot_create_database_with_the_same_name(self):
         name = "Duplicate"
         try:
             self.store.maintenance.server.send(CreateDatabaseOperation(DatabaseRecord(name)))
             TestBase.wait_for_database_topology(self.store, name)
-            self.assertIsNone(self.store.maintenance.server.send(CreateDatabaseOperation(DatabaseRecord(name))))
+            with self.assertRaises(RavenException):
+                self.store.maintenance.server.send(CreateDatabaseOperation(DatabaseRecord(name)))
 
         finally:
             try:

ravendb/tests/raven_commands_tests/test_by_index_actions.py

@@ -2,6 +2,7 @@
 
 from ravendb.documents.commands.query import QueryCommand
 from ravendb.exceptions import exceptions
+from ravendb.exceptions.raven_exceptions import RavenException
 from ravendb.documents.commands.crud import PutDocumentCommand
 from ravendb.documents.indexes.definitions import IndexDefinition
 from ravendb.documents.operations.indexes import PutIndexesOperation
@@ -61,14 +62,13 @@ def test_update_by_index_success(self):
             patch_command.result.operation_node_tag,
         ).wait_for_completion()
 
-    @unittest.skip("Exception dispatcher")
     def test_update_by_index_fail(self):
         index_query = IndexQuery("from index 'TeSort' update {{{0}}}".format(self.patch))
         patch_command = PatchByQueryOperation(
             index_query,
             options=QueryOperationOptions(allow_stale=False),
         ).get_command(self.store, self.store.conventions)
-        with self.assertRaises(exceptions.InvalidOperationException):
+        with self.assertRaises(RavenException):
             self.requests_executor.execute_command(patch_command)
             Operation(
                 self.requests_executor,
@@ -78,12 +78,11 @@ def test_update_by_index_fail(self):
                 patch_command.result.operation_node_tag,
             ).wait_for_completion()
 
-    @unittest.skip("Exception dispatcher")
     def test_delete_by_index_fail(self):
         delete_by_index_command = DeleteByQueryOperation("From Index 'region_2' WHERE Name = 'Western'").get_command(
             self.store, self.store.conventions
         )
-        with self.assertRaises(exceptions.InvalidOperationException):
+        with self.assertRaises(RavenException):
             self.requests_executor.execute_command(delete_by_index_command)
             self.assertIsNotNone(delete_by_index_command.result)
             Operation(

ravendb/tests/raven_commands_tests/test_put.py

@@ -1,4 +1,5 @@
 from ravendb.documents.commands.crud import PutDocumentCommand, GetDocumentsCommand
+from ravendb.exceptions.raven_exceptions import RavenException
 from ravendb.tests.test_base import *
 
 
@@ -17,10 +18,9 @@ def test_put_success(self):
         self.assertEqual(response.results[0]["@metadata"]["@id"], "testing/1")
         request_executor.close()
 
-    @unittest.skip("Exception Dispatcher")
     def test_put_fail(self):
         request_executor = self.store.get_request_executor()
-        with self.assertRaises(ValueError):
+        with self.assertRaises(RavenException):
             command = PutDocumentCommand("testing/2", None, "document")
             request_executor.execute_command(command)