RDBC-1048 Fix SaveChanges dropping batch results after time series and not propagating cluster transaction index

Author: redknightlois

ravendb/documents/operations/batch.py

@@ -127,9 +127,9 @@ def get_command_type(obj_node: dict) -> CommandType:
             elif command_type == CommandType.COUNTERS:
                 self._handle_counters(batch_result)
             elif command_type == CommandType.TIME_SERIES:
-                break  # todo: RavenDB-13474 add to time series cache
+                continue  # todo: RavenDB-13474 add to time series cache
             elif command_type == CommandType.TIME_SERIES_COPY or command_type == CommandType.BATCH_PATCH:
-                break
+                continue
             else:
                 raise ValueError(f"Command {command_type} is not supported")
 

ravendb/documents/session/document_session_operations/in_memory_document_session_operations.py

@@ -1818,9 +1818,10 @@ def _get_operation_result(self, object_type: Type[_T], result: _T) -> _T:
             # todo: cast result on object_type
         raise TypeError(f"Unable to cast {result.__class__.__name__} to {object_type.__name__}")
 
-    # todo: implement method below
     def update_session_after_save_changes(self, result: BatchCommandResult):
         returned_transaction_index = result.transaction_index
+        if returned_transaction_index is not None:
+            self.session_info.last_cluster_transaction_index = returned_transaction_index
 
     def _process_query_parameters(
         self, object_type: type, index_name: str, collection_name: str, conventions: DocumentConventions

ravendb/tests/session_tests/test_time_series.py

@@ -1,3 +1,5 @@
+import unittest
+
 from ravendb.tests.test_base import TestBase, User
 from datetime import datetime, timedelta
 
@@ -65,3 +67,40 @@ def test_time_series_cache(self):
 
             tsf.get(base + timedelta(days=2), base + timedelta(days=6))
             self.assertEqual(session.advanced.number_of_requests, 4)
+
+    def test_batch_processes_all_results_after_time_series(self):
+        with self.store.open_session() as session:
+            session.store(User("Target"), "users/ts-target")
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            session.store(User("NewDoc"), "users/new-doc")
+            tsf = session.time_series_for("users/ts-target", "HeartRate")
+            tsf.append_single(datetime.now(), 70, "watch")
+            session.save_changes()
+
+        with self.store.open_session() as session:
+            new_doc = session.load("users/new-doc", User)
+            self.assertIsNotNone(new_doc, "PUT after time series operation must be processed.")
+            self.assertEqual(new_doc.name, "NewDoc")
+
+
+class TestBatchResultProcessing(unittest.TestCase):
+    def test_batch_does_not_break_after_time_series(self):
+        import inspect
+        from ravendb.documents.operations.batch import BatchOperation
+
+        src = inspect.getsource(BatchOperation)
+        lines = src.split("\n")
+        for i, line in enumerate(lines):
+            if "CommandType.TIME_SERIES" in line:
+                for j in range(i + 1, min(i + 3, len(lines))):
+                    next_line = lines[j].strip()
+                    if next_line and not next_line.startswith("#"):
+                        self.assertNotEqual(
+                            next_line,
+                            "break",
+                            "Batch processing uses 'break' after TIME_SERIES, "
+                            "dropping all subsequent results. Must use 'continue'.",
+                        )
+                        break