Unskip mechanical/stale-API tests; gate license tests on RAVENDB_LICENSE

- License-only tests: @unittest.skip -> skipIf(RAVENDB_LICENSE is None) so they
  run with a license and still skip on license-less CI: server-wide backup,
  documents compression, expiration config, refresh-frequency (<36h).
- OpenAI LLM-integration class: unconditional skip -> skipIf(_OPENAI_KEY is None).
- test_counters: remove stale class skip; number_of_requests_in_session() ->
  number_of_requests (property).
- test_counters_index_creation: unskip; IndexSourceType.counters -> COUNTERS.
- test_stream_query: unskip; session.query(index_name=..) -> query_index(..).
- Remove obsolete test_store_with_metadata_on_dict (unsupported by design;
  covered by test_store_with_metadata_on_api).
- test_use_caching_in_lazy: fix lazily.load arg order; still skipped with an
  accurate reason (MultiGet If-None-Match cache wiring pending, tracked separately).

Author: poissoncorp

ravendb/tests/ai_agent_tests/test_ai_conversation_llm_integration.py

@@ -59,7 +59,7 @@
 # the decorator below or change it back to `@unittest.skipIf(_OPENAI_KEY is None ...)`.
 
 
-@unittest.skip("Needs OpenAI API key — see module docstring to run locally.")
+@unittest.skipIf(_OPENAI_KEY is None, "Needs OpenAI API key. Skipping on CI/CD.")
 class TestAiConversationAgainstRealLLM(TestBase):
     """End-to-end AI conversation tests using a real OpenAI endpoint."""
 

ravendb/tests/documents_tests/peroidic_backup_tests/test_server_wide_backup.py

@@ -1,3 +1,4 @@
+import os
 import unittest
 from typing import List
 
@@ -19,7 +20,7 @@ class TestServerWideBackup(TestBase):
     def setUp(self):
         super().setUp()
 
-    @unittest.skip("Skipping due to license on CI/CD")
+    @unittest.skipIf(os.environ.get("RAVENDB_LICENSE") is None, "Insufficient license permissions. Skipping on CI/CD.")
     def test_can_crud_server_wide_backup(self):
         try:
             put_configuration = ServerWideBackupConfiguration()

ravendb/tests/jvm_migrated_tests/bugs_tests/caching_tests/test_use_caching_in_lazy.py

@@ -17,13 +17,16 @@ class TestUseCachingInLazy(TestBase):
     def setUp(self):
         super(TestUseCachingInLazy, self).setUp()
 
-    @unittest.skip("Aggressive caching in MultiGetCommand")
+    @unittest.skip(
+        "MultiGet create_request does not set If-None-Match from cache, so a repeated not-found "
+        "returns 404 instead of 304 - needs client HTTP-cache wiring (tracked separately)"
+    )
     def test_lazily_load__when_query_not_found_not_modified__should_use_cache(self):
         not_exists_doc_id = "NotExistDocId"
 
         with self.store.open_session() as session:
             # Add "NotExistDocId" to cache
-            session.advanced.lazily.load(TestObj, not_exists_doc_id).value
+            session.advanced.lazily.load(not_exists_doc_id, TestObj).value
 
         request_executor = self.store.get_request_executor()
         with self.store.open_session() as session:

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_13735.py

@@ -1,4 +1,5 @@
 import datetime
+import os
 import time
 import unittest
 
@@ -20,7 +21,7 @@ def _setup_refresh(self, store: DocumentStore) -> None:
 
         store.maintenance.send(ConfigureRefreshOperation(config))
 
-    @unittest.skip("Fails on cicd due to free license - refresh frequency is below allowed 36 hours")
+    @unittest.skipIf(os.environ.get("RAVENDB_LICENSE") is None, "Insufficient license permissions. Skipping on CI/CD.")
     def test_refresh_will_update_document_change_vector(self):
         self._setup_refresh(self.store)
 

ravendb/tests/jvm_migrated_tests/server_tests/test_compress_all_collections.py

@@ -1,3 +1,4 @@
+import os
 import unittest
 
 from ravendb import GetDatabaseRecordOperation, DocumentsCompressionConfiguration
@@ -9,7 +10,7 @@ class TestCompressAllCollections(TestBase):
     def setUp(self):
         super(TestCompressAllCollections, self).setUp()
 
-    @unittest.skip("Skipping due to license on CI/CD")
+    @unittest.skipIf(os.environ.get("RAVENDB_LICENSE") is None, "Insufficient license permissions. Skipping on CI/CD.")
     def test_compress_all_collections_after_docs_change(self):
         # we are running in memory - just check if command will be sent to server
         self.store.maintenance.send(

ravendb/tests/jvm_migrated_tests/server_tests/test_expiration_configuration.py

@@ -1,3 +1,4 @@
+import os
 import unittest
 
 from ravendb import ExpirationConfiguration
@@ -9,7 +10,7 @@ class TestExpirationConfiguration(TestBase):
     def setUp(self):
         super().setUp()
 
-    @unittest.skip("License on ci/cd")
+    @unittest.skipIf(os.environ.get("RAVENDB_LICENSE") is None, "Insufficient license permissions. Skipping on CI/CD.")
     def test_can_setup_expiration(self):
         expiration_configuration = ExpirationConfiguration(False, 5)
         configure_operation = ConfigureExpirationOperation(expiration_configuration)

ravendb/tests/raven_commands_tests/test_index_actions.py

@@ -85,15 +85,14 @@ def test_time_series_index_creation(self):
 
         self.assertEqual(IndexSourceType.TIME_SERIES, index.source_type)
 
-    @unittest.skip("Counters")
     def test_counters_index_creation(self):
         with self.store.open_session() as session:
             user = User("Idan")
             session.store(user, "users/1")
             session.save_changes()
 
         with self.store.open_session() as session:
-            session.counters_for("users/1").increment("Shares", 1)  # todo: implement counters_for
+            session.counters_for("users/1").increment("Shares", 1)
             session.save_changes()
 
         map_ = (
@@ -109,7 +108,7 @@ def test_counters_index_creation(self):
         index_definition.maps = map_
         self.store.maintenance.send(PutIndexesOperation(index_definition))
 
-        self.assertEqual(index_definition.source_type, IndexSourceType.counters)
+        self.assertEqual(index_definition.source_type, IndexSourceType.COUNTERS)
 
 
 if __name__ == "__main__":

ravendb/tests/session_tests/test_advanced.py

@@ -31,7 +31,6 @@ def test_get_document_id_after_save(self):
             id_ = s.advanced.get_document_id(user)
             self.assertFalse(id_.endswith("/"))
 
-    @unittest.skip("Query streaming")
     def test_stream_query(self):
         maps = "from user in docs.Users " "select new {" "name = user.name," "age = user.age}"
         index_definition = IndexDefinition()
@@ -46,7 +45,7 @@ def test_stream_query(self):
             session.save_changes()
 
         with self.store.open_session() as session:
-            query = session.query(object_type=User, index_name="UserByName")
+            query = session.query_index("UserByName", User)
             results = session.advanced.stream(query)
             result_counter = 0
             for _ in results:

ravendb/tests/session_tests/test_counters.py

@@ -8,7 +8,6 @@ def __init__(self, doc_id, name):
         self.name = name
 
 
-@unittest.skip("Counters")
 class TestCounters(TestBase):
     def setUp(self):
         super().setUp()
@@ -65,9 +64,9 @@ def test_counters_cache(self):
             document_counter.get("Shares")
             document_counter.get_all()
 
-            self.assertEqual(session.advanced.number_of_requests_in_session(), 2)
+            self.assertEqual(session.advanced.number_of_requests, 2)
             document_counter.get("Likes")
-            self.assertEqual(session.advanced.number_of_requests_in_session(), 2)
+            self.assertEqual(session.advanced.number_of_requests, 2)
 
 
 if __name__ == "__main__":

ravendb/tests/session_tests/test_store_entities.py

@@ -32,20 +32,6 @@ def test_store_without_key(self):
         with self.store.open_session() as session:
             self.assertIsNotNone(session.load("foos/1-A"))
 
-    # todo: check java/ fix?
-    @unittest.skip("write_metadata method overwrites this metadata preset")
-    def test_store_with_metadata_on_dict(self):
-        foo = Foo("test", 10)
-        foo.__dict__["@metadata"] = {"foo": True}
-        with self.store.open_session() as session:
-            session.store(foo)
-            session.save_changes()
-
-        with self.store.open_session() as session:
-            f = session.load("foos/1-A")
-            metadata = session.advanced.get_metadata_for(f)
-            self.assertTrue(metadata["foo"])
-
     def test_store_with_metadata_on_api(self):
         foo = Foo("test", 10)
         with self.store.open_session() as session: