Skip to content

Commit da49aaa

Browse files
committed
Unskip Corax-limited tests by forcing the Lucene engine
Corax (the 7.x default index engine) does not support proximity, fuzzy, where_lucene, intersect, or explanations. Force Lucene only where the feature needs it: static index classes set search_engine_type=SearchEngineType.LUCENE; dynamic/auto queries set Indexing.Auto.SearchEngineType=Lucene via a _customize_db_record override. - test_ravenDB_12030: test_simple_proximity (static Fox_Search) + test_simple_fuzzy (auto). - test_ravenDB_903: test_test_1/2 intersect (static TestIndex). - test_ravenDB_9745: test_explain explanations (static Companies_ByName + auto). - test_query::test_query_lucene (auto). Full test_query module verified: no regressions.
1 parent 51deffd commit da49aaa

4 files changed

Lines changed: 18 additions & 9 deletions

File tree

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_12030.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import unittest
22

33
from ravendb import AbstractIndexCreationTask
4-
from ravendb.documents.indexes.definitions import FieldIndexing
4+
from ravendb.documents.indexes.definitions import FieldIndexing, SearchEngineType
55
from ravendb.infrastructure.orders import Company
66
from ravendb.tests.test_base import TestBase
77

@@ -14,6 +14,7 @@ def __init__(self, name: str = None):
1414
class Fox_Search(AbstractIndexCreationTask):
1515
def __init__(self):
1616
super(Fox_Search, self).__init__()
17+
self.search_engine_type = SearchEngineType.LUCENE
1718
self.map = "from f in docs.Foxes select new { f.name }"
1819
self._index("name", FieldIndexing.SEARCH)
1920

@@ -22,7 +23,10 @@ class TestRavenDB12030(TestBase):
2223
def setUp(self):
2324
super().setUp()
2425

25-
@unittest.skip("Corax doesn't support proximity")
26+
def _customize_db_record(self, db_record):
27+
# fuzzy is a Lucene-only feature; force the auto-index engine to Lucene
28+
db_record.settings["Indexing.Auto.SearchEngineType"] = "Lucene"
29+
2630
def test_simple_proximity(self):
2731
Fox_Search().execute(self.store)
2832
with self.store.open_session() as session:
@@ -52,7 +56,6 @@ def test_simple_proximity(self):
5256
self.assertEqual("a quick brown fox", foxes[0].name)
5357
self.assertEqual("the fox is quick", foxes[1].name)
5458

55-
@unittest.skip("Corax doesn't support fuzzy")
5659
def test_simple_fuzzy(self):
5760
with self.store.open_session() as session:
5861
hr = Company()

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_903.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import unittest
22
from typing import Callable
33

4-
from ravendb.documents.indexes.definitions import FieldIndexing
4+
from ravendb.documents.indexes.definitions import FieldIndexing, SearchEngineType
55
from ravendb.documents.indexes.abstract_index_creation_tasks import AbstractIndexCreationTask
66
from ravendb.documents.session.document_session import DocumentSession
77
from ravendb.documents.session.query import DocumentQuery
@@ -17,6 +17,7 @@ def __init__(self, name: str = None, description: str = None):
1717
class TestIndex(AbstractIndexCreationTask):
1818
def __init__(self):
1919
super(TestIndex, self).__init__()
20+
self.search_engine_type = SearchEngineType.LUCENE
2021
self.map = "from product in docs.Products select new { product.name, product.description }"
2122
self._index("description", FieldIndexing.SEARCH)
2223

@@ -45,7 +46,6 @@ def do_test(self, query_function: Callable[[DocumentSession], DocumentQuery]):
4546
products = list(query)
4647
self.assertEqual(1, len(products))
4748

48-
@unittest.skip("Corax doesn't support intersect queries")
4949
def test_test_1(self):
5050
def function(session: DocumentSession):
5151
return (
@@ -57,7 +57,6 @@ def function(session: DocumentSession):
5757

5858
self.do_test(function)
5959

60-
@unittest.skip("Corax doesn't support intersect queries")
6160
def test_test_2(self):
6261
def function(session: DocumentSession):
6362
return (

ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_9745.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Optional
33

44
from ravendb import AbstractIndexCreationTask, Explanations, ExplanationOptions
5-
from ravendb.documents.indexes.definitions import FieldStorage
5+
from ravendb.documents.indexes.definitions import FieldStorage, SearchEngineType
66
from ravendb.infrastructure.orders import Company
77
from ravendb.tests.test_base import TestBase
88

@@ -16,6 +16,7 @@ def __init__(self, Id: str = None, key: str = None, count: int = None):
1616

1717
def __init__(self):
1818
super(Companies_ByName, self).__init__()
19+
self.search_engine_type = SearchEngineType.LUCENE
1920
self.map = "from c in docs.Companies select new { key = c.name, count = 1 }"
2021
self.reduce = (
2122
"from result in results "
@@ -34,7 +35,10 @@ class TestRavenDB9745(TestBase):
3435
def setUp(self):
3536
super(TestRavenDB9745, self).setUp()
3637

37-
@unittest.skip("Corax doesn't support explanations yet")
38+
def _customize_db_record(self, db_record):
39+
# explanations on a dynamic query is a Lucene-only feature; force the auto-index engine to Lucene
40+
db_record.settings["Indexing.Auto.SearchEngineType"] = "Lucene"
41+
3842
def test_explain(self):
3943
Companies_ByName().execute(self.store)
4044

ravendb/tests/jvm_migrated_tests/query_tests/test_query.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ class TestQuery(TestBase):
8383
def setUp(self):
8484
super(TestQuery, self).setUp()
8585

86+
def _customize_db_record(self, db_record):
87+
# where_lucene (test_query_lucene) is a Lucene-only method; force the auto-index engine to Lucene
88+
db_record.settings["Indexing.Auto.SearchEngineType"] = "Lucene"
89+
8690
def add_users(self, user_class=UserWithId, args1=None, args2=None, args3=None, **kwargs):
8791
if args3 is None:
8892
args3 = []
@@ -226,7 +230,6 @@ def test_query_first(self):
226230
with self.assertRaises(ValueError):
227231
session.query(object_type=UserWithId).single()
228232

229-
@unittest.skip("Method 'Lucene' is not supported on Corax")
230233
def test_query_lucene(self):
231234
self.add_users()
232235
with self.store.open_session() as session:

0 commit comments

Comments
 (0)