Skip to content

Commit 2838955

Browse files
ravibpatelravibpatel
committed
Fixed issue #7 causing CrashReporter.NET to crash if you change CrashReport Form's property value.
1 parent d737bb1 commit 2838955

30 files changed

Lines changed: 1633 additions & 413 deletions

‎CrashReporter.NET/CrashReport.Designer.cs‎

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎CrashReporter.NET/CrashReport.cs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@
99
using System.Web;
1010
using System.Windows.Forms;
1111
using CrashReporterDotNET.DrDump;
12+
using CrashReporterDotNET.Properties;
1213

1314
namespace CrashReporterDotNET
1415
{
1516
internal partial class CrashReport : Form
1617
{
1718
private readonly ReportCrash _reportCrash;
1819

19-
private readonly ComponentResourceManager _resources = new ComponentResourceManager(typeof (CrashReport));
20-
2120
private ProgressDialog _progressDialog;
2221

2322
private DrDumpService _doctorDumpService;
@@ -27,10 +26,11 @@ internal partial class CrashReport : Form
2726
public CrashReport(ReportCrash reportCrashObject)
2827
{
2928
InitializeComponent();
29+
toolTip.ToolTipTitle = Resources.ToolTipTitle;
3030
_reportCrash = reportCrashObject;
31-
Text = string.Format(_resources.GetString("TitleText"), _reportCrash.ApplicationTitle,
31+
Text = string.Format(Resources.TitleText, _reportCrash.ApplicationTitle,
3232
_reportCrash.ApplicationVersion);
33-
saveFileDialog.FileName = string.Format(_resources.GetString("ReportFileName"),
33+
saveFileDialog.FileName = string.Format(Resources.ReportFileName,
3434
_reportCrash.ApplicationTitle, _reportCrash.ApplicationVersion);
3535
saveFileDialog.Filter = @"HTML files(*.html)|*.html";
3636
if (File.Exists(_reportCrash.ScreenShot))
@@ -102,7 +102,7 @@ private void ButtonSendReportClick(object sender, EventArgs e)
102102
{
103103
if (_reportCrash.EmailRequired)
104104
{
105-
errorProviderEmail.SetError(textBoxEmail, _resources.GetString("EmailRequiredError"));
105+
errorProviderEmail.SetError(textBoxEmail, Resources.EmailRequiredError);
106106
return;
107107
}
108108
}
@@ -113,7 +113,7 @@ private void ButtonSendReportClick(object sender, EventArgs e)
113113
{
114114
if (_reportCrash.EmailRequired)
115115
{
116-
errorProviderEmail.SetError(textBoxEmail, _resources.GetString("InvalidEmailAddressError"));
116+
errorProviderEmail.SetError(textBoxEmail, Resources.InvalidEmailAddressError);
117117
return;
118118
}
119119
}
@@ -197,14 +197,14 @@ private void LinkLabelViewLinkClicked(object sender, LinkLabelLinkClickedEventAr
197197
catch (FileNotFoundException)
198198
{
199199
MessageBox.Show(
200-
_resources.GetString("ErrorCapturingImageMessage"),
201-
_resources.GetString("ErrorCapturingImageCaption"), MessageBoxButtons.OK, MessageBoxIcon.Information);
200+
Resources.ErrorCapturingImageMessage,
201+
Resources.ErrorCapturingImageCaption, MessageBoxButtons.OK, MessageBoxIcon.Information);
202202
}
203203
catch (Exception)
204204
{
205205
MessageBox.Show(
206-
_resources.GetString("NoImageShownMessage"),
207-
_resources.GetString("NoImageShownCaption"), MessageBoxButtons.OK, MessageBoxIcon.Information);
206+
Resources.NoImageShownMessage,
207+
Resources.NoImageShownCaption, MessageBoxButtons.OK, MessageBoxIcon.Information);
208208
}
209209
}
210210

@@ -408,9 +408,9 @@ private void ReportSuccess()
408408
{
409409
_progressDialog.Close();
410410
MessageBox.Show(
411-
string.Format(_resources.GetString("MessageSentMessage"),
411+
string.Format(Resources.MessageSentMessage,
412412
_reportCrash.ApplicationTitle, _reportCrash.ApplicationVersion),
413-
_resources.GetString("MessageSentCaption"), MessageBoxButtons.OK,
413+
Resources.MessageSentCaption, MessageBoxButtons.OK,
414414
MessageBoxIcon.Information);
415415
DialogResult = DialogResult.OK;
416416
}

‎CrashReporter.NET/CrashReport.da.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -132,21 +132,9 @@
132132
<data name="checkBoxIncludeScreenshot.ToolTip" xml:space="preserve">
133133
<value>Tilføj screenshot af fejl skærm i styrt rapport.</value>
134134
</data>
135-
<data name="EmailRequiredError" xml:space="preserve">
136-
<value>En gyldig e-mail-adresse er nødvendig for at sende styrtet rapporten. Dette sikrer, at du vil blive underrettet af bygherren, når fejlen er fast</value>
137-
</data>
138-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
139-
<value>Intet billede fanget</value>
140-
</data>
141-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
142-
<value>Der er en fejl, mens indfange billedet. Du kan indsende rapport rapport uden skærmbillede.</value>
143-
</data>
144135
<data name="groupBoxScreenshot.Text" xml:space="preserve">
145136
<value>Skærmbillede</value>
146137
</data>
147-
<data name="InvalidEmailAddressError" xml:space="preserve">
148-
<value>E-mail-adresse er ikke gyldig. Oplys venligst gyldig e-mail-adresse</value>
149-
</data>
150138
<data name="labelApplication.Text" xml:space="preserve">
151139
<value>Ansøgning</value>
152140
</data>
@@ -177,21 +165,6 @@
177165
<data name="linkLabelView.Text" xml:space="preserve">
178166
<value>View Full Screenshot</value>
179167
</data>
180-
<data name="MessageSentCaption" xml:space="preserve">
181-
<value>Crash rapport sendt</value>
182-
</data>
183-
<data name="MessageSentMessage" xml:space="preserve">
184-
<value>Crash rapport fra {0} {1} er sendt til udvikleren. Tak for din støtte.</value>
185-
</data>
186-
<data name="NoImageShownCaption" xml:space="preserve">
187-
<value>Fejl ved åbning af billede</value>
188-
</data>
189-
<data name="NoImageShownMessage" xml:space="preserve">
190-
<value>Der opstod en fejl, intet billede vil blive vist.</value>
191-
</data>
192-
<data name="ReportFileName" xml:space="preserve">
193-
<value>{0} {1} Crash Report</value>
194-
</data>
195168
<data name="tabPageExceptions.Text" xml:space="preserve">
196169
<value>Undtagelser</value>
197170
</data>
@@ -201,10 +174,4 @@
201174
<data name="tabPageScreenshot.Text" xml:space="preserve">
202175
<value>Skærmbillede</value>
203176
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>{0} {1} styrtede ned.</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>Medtag ansøgning screenshot</value>
209-
</data>
210177
</root>

‎CrashReporter.NET/CrashReport.de.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -132,21 +132,9 @@
132132
<data name="checkBoxIncludeScreenshot.ToolTip" xml:space="preserve">
133133
<value>Screenshot mit dem Fehlerbericht übermitteln</value>
134134
</data>
135-
<data name="EmailRequiredError" xml:space="preserve">
136-
<value>Bitte geben Sie eine gültige Emailadresse an. Dies stellt sicher, dass Sie durch den Entwickler benachrichtigt werden, wenn Fehler behoben ist.</value>
137-
</data>
138-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
139-
<value>Kein Bild erfasst</value>
140-
</data>
141-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
142-
<value>Es ist ein Fehler während der Bildaufnahme aufgetreten. Sie können den Bericht ohne Screenshot senden.</value>
143-
</data>
144135
<data name="groupBoxScreenshot.Text" xml:space="preserve">
145136
<value>Screenshot</value>
146137
</data>
147-
<data name="InvalidEmailAddressError" xml:space="preserve">
148-
<value>E-Mail-Adresse ist nicht gültig. Bitte geben Sie eine gültige E-Mail-Adresse</value>
149-
</data>
150138
<data name="labelApplication.Text" xml:space="preserve">
151139
<value>Anwendung</value>
152140
</data>
@@ -177,21 +165,6 @@
177165
<data name="linkLabelView.Text" xml:space="preserve">
178166
<value>Screenshot anzeigen</value>
179167
</data>
180-
<data name="MessageSentCaption" xml:space="preserve">
181-
<value>Crash-Bericht gesendet</value>
182-
</data>
183-
<data name="MessageSentMessage" xml:space="preserve">
184-
<value>Crash-Bericht von {0} {1} wird an den Entwickler geschickt. Vielen Dank für Ihre Unterstützung.</value>
185-
</data>
186-
<data name="NoImageShownCaption" xml:space="preserve">
187-
<value>Fehler beim Öffnen der Bilddatei</value>
188-
</data>
189-
<data name="NoImageShownMessage" xml:space="preserve">
190-
<value>Fehler aufgetreten, es wird kein Bild angezeigt.</value>
191-
</data>
192-
<data name="ReportFileName" xml:space="preserve">
193-
<value>{0} {1} Crash Report</value>
194-
</data>
195168
<data name="tabPageExceptions.Text" xml:space="preserve">
196169
<value>Ausnahmen</value>
197170
</data>
@@ -201,10 +174,4 @@
201174
<data name="tabPageScreenshot.Text" xml:space="preserve">
202175
<value>Screenshot</value>
203176
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>{0} {1} ist abgestürzt.</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>Anwendungs-Screenshot hinzufügen</value>
209-
</data>
210177
</root>

‎CrashReporter.NET/CrashReport.es.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -174,37 +174,4 @@
174174
<data name="buttonSendReport.Text" xml:space="preserve">
175175
<value>Enviar informe</value>
176176
</data>
177-
<data name="EmailRequiredError" xml:space="preserve">
178-
<value>Una dirección de correo electrónico válida que se requiere con el fin de enviar el informe de errores. Esto garantiza que usted será notificado por el promotor al error se corrige</value>
179-
</data>
180-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
181-
<value>No hay imagen capturada</value>
182-
</data>
183-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
184-
<value>Hay un error durante la captura de la imagen. Puede enviar informe informe sin pantalla.</value>
185-
</data>
186-
<data name="InvalidEmailAddressError" xml:space="preserve">
187-
<value>Dirección de correo electrónico no es válida. Por favor, indique la dirección e-mail válida</value>
188-
</data>
189-
<data name="MessageSentCaption" xml:space="preserve">
190-
<value>Crash informe enviado</value>
191-
</data>
192-
<data name="MessageSentMessage" xml:space="preserve">
193-
<value>Crash informe de {0} {1} es enviado a los desarrolladores. Gracias por tu apoyo.</value>
194-
</data>
195-
<data name="NoImageShownCaption" xml:space="preserve">
196-
<value>Imagen de apertura Error</value>
197-
</data>
198-
<data name="NoImageShownMessage" xml:space="preserve">
199-
<value>Ha ocurrido un error, ninguna imagen aparecerá.</value>
200-
</data>
201-
<data name="ReportFileName" xml:space="preserve">
202-
<value>{0} {1} Informe Crash</value>
203-
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>{0} {1} se estrelló.</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>Incluir la aplicación de pantalla</value>
209-
</data>
210177
</root>

‎CrashReporter.NET/CrashReport.fr.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -174,37 +174,4 @@
174174
<data name="buttonSendReport.Text" xml:space="preserve">
175175
<value>Envoyer un rapport</value>
176176
</data>
177-
<data name="EmailRequiredError" xml:space="preserve">
178-
<value>Une adresse électronique valide est nécessaire pour envoyer le rapport d'accident. Cela garantit que vous en serez informé par le développeur lors de bug est corrigé</value>
179-
</data>
180-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
181-
<value>Aucune image capturée</value>
182-
</data>
183-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
184-
<value>Il ya une erreur lors de la capture d'image. Vous pouvez soumettre un rapport d'état sans écran.</value>
185-
</data>
186-
<data name="InvalidEmailAddressError" xml:space="preserve">
187-
<value>Adresse e-mail n'est pas valide. S'il vous plaît fournir l'adresse e-mail valide</value>
188-
</data>
189-
<data name="MessageSentCaption" xml:space="preserve">
190-
<value>rapport d'accident envoyé</value>
191-
</data>
192-
<data name="MessageSentMessage" xml:space="preserve">
193-
<value>Accident rapport de {0} {1} est envoyé au promoteur. Merci pour votre soutien.</value>
194-
</data>
195-
<data name="NoImageShownCaption" xml:space="preserve">
196-
<value>image d'ouverture d'erreur</value>
197-
</data>
198-
<data name="NoImageShownMessage" xml:space="preserve">
199-
<value>Une erreur s'est produite, aucune image ne sera affichée.</value>
200-
</data>
201-
<data name="ReportFileName" xml:space="preserve">
202-
<value>{0} {1} rapport de crash</value>
203-
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>{0} {1} s'est écrasé.</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>Inclure l'application d'écran</value>
209-
</data>
210177
</root>

‎CrashReporter.NET/CrashReport.it.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -174,37 +174,4 @@
174174
<data name="buttonSendReport.Text" xml:space="preserve">
175175
<value>Invia segnalazione</value>
176176
</data>
177-
<data name="EmailRequiredError" xml:space="preserve">
178-
<value>Se decidi di inserire un indirizzo e-mail, è necessario che sia valido per inviare il crash report. Solo in questo modo potari essere ricontattato dallo sviluppatore quando il bug verrà risolto.</value>
179-
</data>
180-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
181-
<value>Nessuna immagine catturata</value>
182-
</data>
183-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
184-
<value>C'è stato un errore durante la cattura dell'immagine. È comunque possibile inviare il rapporto senza screenshot.</value>
185-
</data>
186-
<data name="InvalidEmailAddressError" xml:space="preserve">
187-
<value>Indirizzo e-mail non valido. Si prega di fornire indirizzo e-mail valido</value>
188-
</data>
189-
<data name="MessageSentCaption" xml:space="preserve">
190-
<value>Crash report inviato</value>
191-
</data>
192-
<data name="MessageSentMessage" xml:space="preserve">
193-
<value>Il rapporto di chiusura inaspettata (crash report) per il programma {0} - versione {1} è stato inviato allo sviluppatore. Grazie per il vostro supporto.</value>
194-
</data>
195-
<data name="NoImageShownCaption" xml:space="preserve">
196-
<value>Apertura immagine di errore</value>
197-
</data>
198-
<data name="NoImageShownMessage" xml:space="preserve">
199-
<value>Errore, nessuna immagine visualizzata.</value>
200-
</data>
201-
<data name="ReportFileName" xml:space="preserve">
202-
<value>{0} {1} crash report</value>
203-
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>Il programma {0} - versione {1} si è chiuso in modo imprevisto.</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>Includi lo screenshot</value>
209-
</data>
210177
</root>

‎CrashReporter.NET/CrashReport.ko.resx‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -132,21 +132,9 @@
132132
<data name="checkBoxIncludeScreenshot.ToolTip" xml:space="preserve">
133133
<value>에러 리포트에 에러 발생 당시의 화면을 첨부합니다.</value>
134134
</data>
135-
<data name="EmailRequiredError" xml:space="preserve">
136-
<value>에러 리포트 전송을 위해 올바른 메일 주소가 필요합니다. 또한 버그가 수정되면 개발자로부터 알림을 받으실 수 있습니다.</value>
137-
</data>
138-
<data name="ErrorCapturingImageCaption" xml:space="preserve">
139-
<value>캡쳐된 이미지 없음.</value>
140-
</data>
141-
<data name="ErrorCapturingImageMessage" xml:space="preserve">
142-
<value>스크린샷을 찍는 도중에 에러가 발생하였습니다. 스크린샷 없이도 에러 리포트를 보낼 수 있습니다.</value>
143-
</data>
144135
<data name="groupBoxScreenshot.Text" xml:space="preserve">
145136
<value>스크린샷</value>
146137
</data>
147-
<data name="InvalidEmailAddressError" xml:space="preserve">
148-
<value>이메일이 올바르지 않습니다. 올바른 이메일을 적어주세요.</value>
149-
</data>
150138
<data name="labelApplication.Text" xml:space="preserve">
151139
<value>애플리케이션</value>
152140
</data>
@@ -177,21 +165,6 @@
177165
<data name="linkLabelView.Text" xml:space="preserve">
178166
<value>스크린샷 크게 보기</value>
179167
</data>
180-
<data name="MessageSentCaption" xml:space="preserve">
181-
<value>에러 리포트가 전송되었습니다.</value>
182-
</data>
183-
<data name="MessageSentMessage" xml:space="preserve">
184-
<value>에러리포트 {0} {1} 가 개발자에게 전송되었습니다. 도움을 주셔서 감사합니다.</value>
185-
</data>
186-
<data name="NoImageShownCaption" xml:space="preserve">
187-
<value>이미지를 여는데 실패함.</value>
188-
</data>
189-
<data name="NoImageShownMessage" xml:space="preserve">
190-
<value>에러 발생, 이미지가 표시되지 않습니다.</value>
191-
</data>
192-
<data name="ReportFileName" xml:space="preserve">
193-
<value>{0} {1} 에러 리포트.</value>
194-
</data>
195168
<data name="tabPageExceptions.Text" xml:space="preserve">
196169
<value>에러 내용</value>
197170
</data>
@@ -201,10 +174,4 @@
201174
<data name="tabPageScreenshot.Text" xml:space="preserve">
202175
<value>스크린샷</value>
203176
</data>
204-
<data name="TitleText" xml:space="preserve">
205-
<value>{0} {1} 크래시 발생</value>
206-
</data>
207-
<data name="toolTip.ToolTipTitle" xml:space="preserve">
208-
<value>애플리케이션 스크린샷 포함</value>
209-
</data>
210177
</root>

0 commit comments

Comments
 (0)