Add a shortcut integration#32
Open
vanilevsky wants to merge 13 commits intoravilushqa:mainfrom
Open
Conversation
4594511 to
d64de60
Compare
ravilushqa
requested changes
Jul 18, 2023
| @@ -0,0 +1 @@ | |||
| gpt-updater:description | |||
Owner
There was a problem hiding this comment.
I don't think this related to shortcut, do you mind to create a new PR for that?
| const placeholder = "gpt-updater:description" | ||
| const placeholderFinished = "<!-- gpt-updater:description -->" | ||
|
|
||
| type Info struct { |
Owner
There was a problem hiding this comment.
The structure doesn't look flexible and, in my opinion, needs improvement. What do you think about keeping the old flat logic without an extra structure and simply validating that only JIRA or shortcut are allowed? If both are passed, then return an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The development work done was primarily focused on integrating a new shortcut feature into the existing codebase. This involved creating new functions, updating existing ones, and writing tests to ensure the functionality works as expected. The changes were made across six files, including the addition of a new file.
Changes
.github/pull_request_template.mdREADME.mddescriptioncommand to include a new--shortcut-urloption.cmd/description/main.godescription/description.goInfo.BuildUpdatedPullRequestfunction to construct a new pull request description based on the providedInfostruct.IsDescriptionFinishedandneedToUpdateByPlaceholderfunctions to check if a pull request description contains certain placeholders.stringspackage.shortcut/shortcut.goshortcut/shortcut_test.goImpact
These changes will allow users to generate Shortcut links more efficiently and customize their pull request descriptions. The new tests ensure that the new functions work as expected, increasing the reliability of the code. The changes also improve the readability and maintainability of the code by introducing a new structure and modifying the way information is generated and stored.