Skip to content

Delete buffers after the window has closed #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravitemer merged 3 commits into from
Jan 15, 2026
Merged

Delete buffers after the window has closed #263

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4936fd1
fix: Delete confirmation window buffers after closing.
slg95 Jan 5, 2026
ab63d97
fix: Delete auth popup window buffers after closing.
slg95 Jan 5, 2026
5728dba
Explicitly delete multiline_input buffers after closing.
slg95 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions lua/mcphub/utils/ui.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,27 @@ function M.multiline_input(title, content, on_save, opts)
end
end
-- Close the window
vim.api.nvim_win_close(win, true)
if vim.api.nvim_win_is_valid(win) then
vim.api.nvim_win_close(win, true)
end

if vim.api.nvim_buf_is_valid(bufnr) then
vim.api.nvim_buf_delete(bufnr, { force = true })
end
-- -- Call save callback if content changed
-- if content ~= new_content then
on_save(new_content)
-- end
end

local function close_window()
vim.api.nvim_win_close(win, true)
if vim.api.nvim_win_is_valid(win) then
vim.api.nvim_win_close(win, true)
end

if vim.api.nvim_buf_is_valid(bufnr) then
vim.api.nvim_buf_delete(bufnr, { force = true })
end
if opts.on_cancel then
opts.on_cancel()
end
Expand Down Expand Up @@ -388,9 +400,11 @@ function M.confirm(message, opts)

vim.schedule(function()
if vim.api.nvim_win_is_valid(win) then
if vim.api.nvim_win_is_valid(win) then
vim.api.nvim_win_close(win, true)
end
vim.api.nvim_win_close(win, true)
end

if vim.api.nvim_buf_is_valid(bufnr) then
vim.api.nvim_buf_delete(bufnr, { force = true })
end
callback(confirmed, cancelled)
end)
Expand Down Expand Up @@ -605,6 +619,13 @@ function M.open_auth_popup(server_name, auth_url)
if vim.api.nvim_win_is_valid(input_win) then
vim.api.nvim_win_close(input_win, true)
end

if vim.api.nvim_buf_is_valid(info_buf) then
vim.api.nvim_buf_delete(info_buf, { force = true })
end
if vim.api.nvim_buf_is_valid(input_buf) then
vim.api.nvim_buf_delete(input_buf, { force = true })
end
-- Return focus to MCPHub window
if State.ui_instance and State.ui_instance.window then
vim.api.nvim_set_current_win(State.ui_instance.window)
Expand Down
Loading