Skip to content

[Refactor] Use RayNodeTypeLabelKey constant in CalculateAvailableRepl…#4950

Merged
andrewsykim merged 1 commit into
ray-project:masterfrom
dalaoqi:refactor/use-raynodetype-constant
Jul 18, 2026
Merged

[Refactor] Use RayNodeTypeLabelKey constant in CalculateAvailableRepl…#4950
andrewsykim merged 1 commit into
ray-project:masterfrom
dalaoqi:refactor/use-raynodetype-constant

Conversation

@dalaoqi

@dalaoqi dalaoqi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Why are these changes needed?

CalculateAvailableReplicas was using the hardcoded string "ray.io/node-type".
This refactor replaces it with the existing RayNodeTypeLabelKey constant, matching how the sibling function CalculateReadyReplicas already references the label.

Related issue number

Closes #4948

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

…icas (ray-project#4948)

Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>

@Future-Outlier Future-Outlier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machichima machichima left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsykim
andrewsykim merged commit 4a28143 into ray-project:master Jul 18, 2026
32 checks passed
@github-project-automation github-project-automation Bot moved this from can be merged to Done in @Future-Outlier's kuberay project Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Use RayNodeTypeLabelKey constant instead of hardcoded "ray.io/node-type" in CalculateAvailableReplicas

5 participants