refactor: simplify Generate signature and rename variables (main)

rayakame · rayakame · commit 034ef199d520 · 2025-03-26T03:01:51.000+01:00
diff --git a/internal/gen.go b/internal/gen.go
@@ -50,7 +50,7 @@ func (pg *PythonGenerator) Run() (*plugin.GenerateResponse, error) {
 	return &plugin.GenerateResponse{Files: outputFiles}, nil
 }
 
-func Generate(ctx context.Context, req *plugin.GenerateRequest) (*plugin.GenerateResponse, error) {
+func Generate(_ context.Context, req *plugin.GenerateRequest) (*plugin.GenerateResponse, error) {
 	pythonGenerator, err := NewPythonGenerator(req)
 	if err != nil {
 		return nil, err
diff --git a/internal/types/sqlite.go b/internal/types/sqlite.go
@@ -8,7 +8,7 @@ import (
 	"github.com/sqlc-dev/plugin-sdk-go/sdk"
 )
 
-func SqliteTypeToPython(req *plugin.GenerateRequest, col *plugin.Column) string {
+func SqliteTypeToPython(_ *plugin.GenerateRequest, col *plugin.Column) string {
 	columnType := strings.ToLower(sdk.DataType(col.Type))
 
 	// see: https://github.com/sqlc-dev/sqlc/blob/main/internal/codegen/golang/sqlite_type.go

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func (pg PythonGenerator) Run() (plugin.GenerateResponse, error) {`
`50`	`50`	`return &plugin.GenerateResponse{Files: outputFiles}, nil`
`51`	`51`	`}`
`52`	`52`
`53`		`-func Generate(ctx context.Context, req plugin.GenerateRequest) (plugin.GenerateResponse, error) {`
	`53`	`+func Generate(_ context.Context, req plugin.GenerateRequest) (plugin.GenerateResponse, error) {`
`54`	`54`	`pythonGenerator, err := NewPythonGenerator(req)`
`55`	`55`	`if err != nil {`
`56`	`56`	`return nil, err`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`	`"github.com/sqlc-dev/plugin-sdk-go/sdk"`
`9`	`9`	`)`
`10`	`10`
`11`		`-func SqliteTypeToPython(req plugin.GenerateRequest, col plugin.Column) string {`
	`11`	`+func SqliteTypeToPython(_ plugin.GenerateRequest, col plugin.Column) string {`
`12`	`12`	`columnType := strings.ToLower(sdk.DataType(col.Type))`
`13`	`13`
`14`	`14`	`// see: https://github.com/sqlc-dev/sqlc/blob/main/internal/codegen/golang/sqlite_type.go`