copilot feedback

Author: rayokota

noxfile.py

@@ -63,7 +63,10 @@ def test_re2(session):
     build_and_check_dists(session)
 
     generated_files = os.listdir("dist/")
-    generated_sdist = os.path.join("dist/", generated_files[1])
+    sdists = sorted(f for f in generated_files if f.endswith(".tar.gz"))
+    if not sdists:
+        session.error("No sdist (.tar.gz) found in dist/")
+    generated_sdist = os.path.join("dist/", sdists[0])
 
     session.install(generated_sdist)
 

src/jsonata/functions.py

@@ -2025,8 +2025,14 @@ def is_lambda(result: Optional[Any]) -> bool:
     #
     @staticmethod
     def is_regex(value: Optional[Any]) -> bool:
-        return isinstance(value, re.Pattern) or (
-            hasattr(value, "search") and hasattr(value, "finditer") and hasattr(value, "sub")
+        if isinstance(value, re.Pattern):
+            return True
+        if value is None or inspect.ismodule(value) or inspect.isclass(value):
+            return False
+        return (
+            callable(getattr(value, "search", None))
+            and callable(getattr(value, "finditer", None))
+            and callable(getattr(value, "sub", None))
         )
 
     #

src/jsonata/jsonata.py

@@ -1887,8 +1887,9 @@ def _static_initializer() -> None:
     # JSONata
     # @param {Object} expr - JSONata expression
     # @param {Object} regex_engine - module/object providing a `compile(pattern, flags)`
-    #     function compatible with the stdlib `re` module (e.g. `re2`), used to compile
-    #     JSONata regex literals. Defaults to the stdlib `re` module.
+    #     function compatible with the stdlib `re` module (or an adapter that exposes
+    #     this interface for engines like `google-re2`), used to compile JSONata regex
+    #     literals. Defaults to the stdlib `re` module.
     # @returns Evaluated expression
     # @throws jexception.JException An exception if an error occured.
     #