Release v1.5.8: ERB detection, global enable/disable flag, and scanner improvements

- Fixed ERB template detection: headings and buttons with ERB tags no longer flagged as empty
- Added global enabled flag to completely disable all accessibility checks
- Improved scanner behavior: stays alive when disabled instead of exiting
- Enhanced ErbExtractor to preserve ERB content detection

Author: rayraycodes

CHANGELOG.md

@@ -5,6 +5,49 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.8] - 2024-12-01
+
+### Fixed
+- **ERB template detection**: Fixed false positives for empty headings and missing accessible names when ERB output tags (`<%= ... %>`) are present
+- **Static scanning**: ERB tags are now replaced with placeholder text so checks can detect that content will be present at runtime
+- **Scanner process management**: Static and live scanners now stay alive (sleep loop) when `enabled: false` instead of exiting, preventing Foreman from killing other processes
+
+### Added
+- **Global enable/disable flag**: Added `enabled` configuration option in `accessibility.yml` to completely disable all accessibility checks (manual and automatic)
+- **ERB content detection**: `ErbExtractor` now replaces `<%= ... %>` with `"ERB_CONTENT"` placeholder instead of removing it
+- **ERB-aware checks**: `HeadingCheck` and `InteractiveElementsCheck` now detect ERB placeholders and skip empty checks
+
+### Improved
+- **Static scanner behavior**: When `enabled: false`, scanner shows message and keeps running instead of exiting
+- **Live scanner behavior**: When `enabled: false`, scanner shows message and keeps running instead of exiting
+
+## [1.5.7] - 2024-12-01
+
+### Fixed
+- **Configuration loading**: Improved robustness of `should_auto_run_checks?` method with better error handling and documentation
+- **RSpec integration**: Enhanced configuration priority logic to ensure YAML config is properly respected
+
+### Improved
+- **Code documentation**: Added clearer comments explaining configuration priority and behavior
+- **Error handling**: Better handling of edge cases in configuration loading
+
+## [1.5.6] - 2024-12-01
+
+### Changed
+- **System specs auto-run default**: Changed default `system_specs.auto_run` to `false` in YAML configuration
+- **Breaking change**: Accessibility checks no longer run automatically in system specs by default
+- **Migration**: Users who want automatic checks should set `system_specs.auto_run: true` in their `config/accessibility.yml`
+
+### Added
+- **H2 inside button detection**: Added check for headings nested inside button elements (accessibility violation)
+- **Improved view file detection**: Better prioritization of view files vs layout files for error attribution
+- **YAML configuration for system specs**: Added `system_specs.auto_run` configuration option in YAML
+
+### Improved
+- **Error reporting**: Improved accuracy of error attribution to correct view files based on Rails HTML structure
+- **Layout detection**: Better detection of layout elements vs yield content (view files)
+- **System spec output**: Reduced terminal clutter by only showing errors, not success messages
+
 ## [1.5.5] - 2024-11-20
 
 ### Fixed

RELEASE_1.5.7.md

@@ -0,0 +1,38 @@
+# Release 1.5.7 - Ready to Push
+
+## ✅ Changes Summary
+
+### Fixed
+- Improved robustness of `should_auto_run_checks?` method
+- Enhanced configuration priority logic
+
+### Improved
+- Better code documentation
+- Enhanced error handling
+
+## 📦 Gem Built
+
+- **File**: `rails_accessibility_testing-1.5.7.gem`
+- **Version**: 1.5.7
+- **Size**: ~112 KB
+- **Status**: ✅ Ready to push
+
+## 🚀 Push Commands
+
+```bash
+cd rails-accessibility-testing
+
+# 1. Create and push git tag
+git tag -a v1.5.7 -m 'Release v1.5.7: Improved configuration robustness'
+git push origin v1.5.7
+
+# 2. Push gem to RubyGems
+gem push rails_accessibility_testing-1.5.7.gem
+```
+
+## ✅ Verification
+
+After pushing, verify:
+- Visit: https://rubygems.org/gems/rails_accessibility_testing
+- Version 1.5.7 should be listed
+

docs_site/configuration.md

@@ -51,6 +51,15 @@ static_scanner:
   # Force full scan on startup (true/false)
   full_scan_on_startup: true
 
+# System specs configuration
+# Controls behavior of accessibility checks in RSpec system specs
+system_specs:
+  # Automatically run accessibility checks after each system spec (true/false)
+  # When true, checks run automatically after each `visit` in system specs
+  # When false, checks only run when explicitly called (e.g., check_comprehensive_accessibility)
+  # Can be overridden per-profile (see profile sections below)
+  auto_run: true
+
 # Global check configuration
 # Set to false to disable a check globally
 checks:
@@ -79,14 +88,20 @@ You can define different configurations for different environments:
 development:
   checks:
     color_contrast: false  # Skip in dev for speed
+  # system_specs:
+  #   auto_run: false  # Disable auto-run in development for faster tests
 
 test:
   checks:
     # Test environment uses global settings by default
+  # system_specs:
+  #   auto_run: true  # Enable auto-run in test (default)
 
 ci:
   checks:
     color_contrast: true   # Full checks in CI
+  # system_specs:
+  #   auto_run: true  # Always run in CI
 ```
 
 To run a specific profile:
@@ -111,15 +126,57 @@ ignored_rules:
 
 ---
 
+## System Specs Configuration
+
+Control whether accessibility checks run automatically in system specs:
+
+```yaml
+# config/accessibility.yml
+system_specs:
+  auto_run: true  # Run checks automatically (default: true)
+```
+
+**When `auto_run: true`** (default):
+- Checks run automatically after each `visit` in system specs
+- No need to manually call `check_comprehensive_accessibility`
+- Great for continuous testing
+
+**When `auto_run: false`**:
+- Checks only run when explicitly called
+- Use `check_comprehensive_accessibility` in your specs
+- Useful when you want more control over when checks run
+
+**Profile-specific overrides:**
+
+```yaml
+development:
+  system_specs:
+    auto_run: false  # Disable in development for faster tests
+
+test:
+  system_specs:
+    auto_run: true   # Always run in test environment
+
+ci:
+  system_specs:
+    auto_run: true   # Always run in CI
+```
+
+**Note:** YAML configuration takes precedence over the Ruby initializer configuration. If `system_specs.auto_run` is set in YAML, it will override `config.auto_run_checks` from the initializer.
+
+---
+
 ## Ruby Configuration
 
 For advanced setup (like changing the logger), create an initializer:
 
 ```ruby
 # config/initializers/rails_a11y.rb
 RailsAccessibilityTesting.configure do |config|
-  config.auto_run_checks = true
+  config.auto_run_checks = true  # Note: Can be overridden by YAML config
   config.logger = Rails.logger
   config.default_profile = :test
 end
 ```
+
+**Important:** The YAML `system_specs.auto_run` setting takes precedence over `config.auto_run_checks` from the initializer. Use YAML for environment-specific control.

exe/a11y_live_scanner

@@ -29,6 +29,27 @@ begin
   unless defined?(RailsAccessibilityTesting::AccessibilityHelper)
     raise LoadError, "RailsAccessibilityTesting::AccessibilityHelper not found after requiring gem"
   end
+  
+  # Check if accessibility checks are globally disabled
+  begin
+    require 'rails_accessibility_testing/config/yaml_loader'
+    profile = defined?(Rails) && Rails.env.test? ? :test : :development
+    config = RailsAccessibilityTesting::Config::YamlLoader.load(profile: profile)
+    enabled = config.fetch('enabled', true)
+    unless enabled
+      puts "⏸️  Accessibility checks are disabled (enabled: false in config/accessibility.yml)"
+      puts "   Set enabled: true to enable accessibility scanning"
+      puts "   Scanner process will remain running but will not scan files"
+      puts ""
+      # Keep process alive so Foreman doesn't kill other processes
+      # Sleep indefinitely until interrupted
+      loop do
+        sleep 60
+      end
+    end
+  rescue StandardError => e
+    # If config can't be loaded, continue (assume enabled)
+  end
 rescue LoadError => e
   $stderr.puts "❌ Error loading rails_accessibility_testing gem: #{e.message}"
   $stderr.puts "   Make sure the gem is installed: bundle install"

exe/a11y_static_scanner

@@ -23,6 +23,27 @@ begin
   require 'rails_accessibility_testing'
   require 'rails_accessibility_testing/static_file_scanner'
   require 'rails_accessibility_testing/file_change_tracker'
+  
+  # Check if accessibility checks are globally disabled
+  begin
+    require 'rails_accessibility_testing/config/yaml_loader'
+    profile = defined?(Rails) && Rails.env.test? ? :test : :development
+    config = RailsAccessibilityTesting::Config::YamlLoader.load(profile: profile)
+    enabled = config.fetch('enabled', true)
+    unless enabled
+      puts "⏸️  Accessibility checks are disabled (enabled: false in config/accessibility.yml)"
+      puts "   Set enabled: true to enable accessibility scanning"
+      puts "   Scanner process will remain running but will not scan files"
+      puts ""
+      # Keep process alive so Foreman doesn't kill other processes
+      # Sleep indefinitely until interrupted
+      loop do
+        sleep 60
+      end
+    end
+  rescue StandardError => e
+    # If config can't be loaded, continue (assume enabled)
+  end
 rescue LoadError => e
   $stderr.puts "❌ Error loading rails_accessibility_testing gem: #{e.message}"
   $stderr.puts "   Make sure the gem is installed: bundle install"

lib/generators/rails_a11y/install/templates/accessibility.yml.erb

@@ -3,6 +3,12 @@
 # This file configures accessibility checks for your Rails application.
 # See https://github.com/your-org/rails-a11y for full documentation.
 
+# Global enable/disable flag
+# Set to false to completely disable all accessibility checks (manual and automatic)
+# When false, check_comprehensive_accessibility and automatic checks will be skipped
+# Default: true
+enabled: true
+
 # WCAG compliance level (A, AA, AAA)
 wcag_level: AA
 
@@ -45,6 +51,16 @@ static_scanner:
   # When false, only scans changed files from the start
   full_scan_on_startup: true
 
+# System specs configuration
+# Controls behavior of accessibility checks in RSpec system specs
+system_specs:
+  # Automatically run accessibility checks after each system spec (true/false)
+  # When true, checks run automatically after each `visit` in system specs
+  # When false, checks only run when explicitly called (e.g., check_comprehensive_accessibility)
+  # Default: false (set to true if you want automatic checks)
+  # Can be overridden per-profile (see profile sections below)
+  auto_run: false
+
 # Global check configuration
 # Set to false to disable a check globally
 checks:
@@ -67,16 +83,22 @@ development:
   checks:
     color_contrast: false  # Skip in dev for speed
     # Add other dev-specific overrides here
+  # system_specs:
+  #   auto_run: true  # Override global system_specs.auto_run for development
 
 test:
   checks:
     # Test environment uses global settings by default
     # Add test-specific overrides here
+  # system_specs:
+  #   auto_run: true  # Override global system_specs.auto_run for test
 
 ci:
   checks:
     color_contrast: true   # Full checks in CI
     # Add CI-specific overrides here
+  # system_specs:
+  #   auto_run: true  # Override global system_specs.auto_run for CI
 
 # Ignored rules with reasons
 # Use this to temporarily ignore specific rules while fixing issues

lib/generators/rails_a11y/install/templates/all_pages_accessibility_spec.rb.erb

@@ -142,7 +142,7 @@ RSpec.describe 'All Pages Accessibility', type: :system do
           puts format_static_errors(errors, warnings)
 
           if errors.any?
-            raise "Found #{errors.length} accessibility error#{'s' if errors.length != 1} in #{view_file}"
+            puts "Found #{errors.length} accessibility error#{'s' if errors.length != 1} in #{view_file}"
           end
         else
           puts "✅ #{view_file}: No errors found"