WARNING: Not updating mouse.previousPosition when SeMousePosition() #5962

raysan5 · raysan5 · commit 4640c8492080 · 2026-07-13T19:32:30.000+02:00
This could be a sensible change, not sure if it can break anything...
diff --git a/src/platforms/rcore_android.c b/src/platforms/rcore_android.c
@@ -726,7 +726,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_desktop_glfw.c b/src/platforms/rcore_desktop_glfw.c
@@ -1237,7 +1237,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 
     // NOTE: emscripten not implemented
     glfwSetCursorPos(platform.handle, CORE.Input.Mouse.currentPosition.x, CORE.Input.Mouse.currentPosition.y);
diff --git a/src/platforms/rcore_desktop_rgfw.c b/src/platforms/rcore_desktop_rgfw.c
@@ -1526,7 +1526,6 @@ void SetMousePosition(int x, int y)
 {
     RGFW_window_moveMouse(platform.window, x, y);
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_desktop_sdl.c b/src/platforms/rcore_desktop_sdl.c
@@ -1411,7 +1411,6 @@ void SetMousePosition(int x, int y)
     SDL_WarpMouseInWindow(platform.window, x, y);
 
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_desktop_win32.c b/src/platforms/rcore_desktop_win32.c
@@ -1299,8 +1299,8 @@ void SetMousePosition(int x, int y)
     if (!CORE.Input.Mouse.cursorLocked)
     {
         CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-        CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
-        TRACELOG(LOG_WARNING, "SetMousePosition not implemented");
+        
+        TRACELOG(LOG_WARNING, "SetMousePosition not implemented at platform level");
     }
     else TRACELOG(LOG_WARNING, "INPUT: MOUSE: Cursor not enabled");
 }
diff --git a/src/platforms/rcore_drm.c b/src/platforms/rcore_drm.c
@@ -1042,7 +1042,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_memory.c b/src/platforms/rcore_memory.c
@@ -420,7 +420,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_template.c b/src/platforms/rcore_template.c
@@ -395,7 +395,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 }
 
 // Set mouse cursor
diff --git a/src/platforms/rcore_web.c b/src/platforms/rcore_web.c
@@ -1047,7 +1047,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d
 void SetMousePosition(int x, int y)
 {
     CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };
-    CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;
 
     if (CORE.Input.Mouse.cursorLocked) CORE.Input.Mouse.lockedPosition = CORE.Input.Mouse.currentPosition;
 

Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`726`	`726`	`void SetMousePosition(int x, int y)`
`727`	`727`	`{`
`728`	`728`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`729`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`730`	`729`	`}`
`731`	`730`
`732`	`731`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -1237,7 +1237,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`1237`	`1237`	`void SetMousePosition(int x, int y)`
`1238`	`1238`	`{`
`1239`	`1239`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1240`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1241`	`1240`
`1242`	`1241`	`// NOTE: emscripten not implemented`
`1243`	`1242`	`glfwSetCursorPos(platform.handle, CORE.Input.Mouse.currentPosition.x, CORE.Input.Mouse.currentPosition.y);`
Original file line number	Diff line number	Diff line change
`@@ -1526,7 +1526,6 @@ void SetMousePosition(int x, int y)`
`1526`	`1526`	`{`
`1527`	`1527`	`RGFW_window_moveMouse(platform.window, x, y);`
`1528`	`1528`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1529`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1530`	`1529`	`}`
`1531`	`1530`
`1532`	`1531`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -1411,7 +1411,6 @@ void SetMousePosition(int x, int y)`
`1411`	`1411`	`SDL_WarpMouseInWindow(platform.window, x, y);`
`1412`	`1412`
`1413`	`1413`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1414`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1415`	`1414`	`}`
`1416`	`1415`
`1417`	`1416`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -1299,8 +1299,8 @@ void SetMousePosition(int x, int y)`
`1299`	`1299`	`if (!CORE.Input.Mouse.cursorLocked)`
`1300`	`1300`	`{`
`1301`	`1301`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1302`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1303`		`- TRACELOG(LOG_WARNING, "SetMousePosition not implemented");`
	`1302`	`+`
	`1303`	`+ TRACELOG(LOG_WARNING, "SetMousePosition not implemented at platform level");`
`1304`	`1304`	`}`
`1305`	`1305`	`else TRACELOG(LOG_WARNING, "INPUT: MOUSE: Cursor not enabled");`
`1306`	`1306`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1042,7 +1042,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`1042`	`1042`	`void SetMousePosition(int x, int y)`
`1043`	`1043`	`{`
`1044`	`1044`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1045`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1046`	`1045`	`}`
`1047`	`1046`
`1048`	`1047`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`420`	`420`	`void SetMousePosition(int x, int y)`
`421`	`421`	`{`
`422`	`422`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`423`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`424`	`423`	`}`
`425`	`424`
`426`	`425`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`395`	`395`	`void SetMousePosition(int x, int y)`
`396`	`396`	`{`
`397`	`397`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`398`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`399`	`398`	`}`
`400`	`399`
`401`	`400`	`// Set mouse cursor`
Original file line number	Diff line number	Diff line change
`@@ -1047,7 +1047,6 @@ void SetGamepadVibration(int gamepad, float leftMotor, float rightMotor, float d`
`1047`	`1047`	`void SetMousePosition(int x, int y)`
`1048`	`1048`	`{`
`1049`	`1049`	`CORE.Input.Mouse.currentPosition = (Vector2){ (float)x, (float)y };`
`1050`		`- CORE.Input.Mouse.previousPosition = CORE.Input.Mouse.currentPosition;`
`1051`	`1050`
`1052`	`1051`	`if (CORE.Input.Mouse.cursorLocked) CORE.Input.Mouse.lockedPosition = CORE.Input.Mouse.currentPosition;`
`1053`	`1052`