[examples] REVIEW: core_3d_camera_free uses IsKeyPressed() incorrectly#5223
Merged
Conversation
raysan5
changed the title
core_3d_camera_free uses IsKeyPressed() incorrectly
Owner
|
@RobinsAviary Good catch! Actually, it also used to work this way in the past, long time ago... |
Contributor
Author
The irony is it still technically works, I got it to compile and it still technically functioned the same on my pc LOL. I'm assuming the ascii codes of each char just happen to line up with the constants tho |
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I noticed core_3d_camera_free uses a char in place of the constants that it is supposed to be using. I don't see this repeated in other examples, so I think it would be better to replace it with the constant to prevent future confusion.