[rlsw] Completeness of glDraw functions#5304
Merged
Merged
Conversation
Bigfoot71
changed the title
glDraw functionsglDraw functions
Owner
|
@Bigfoot71 Oh! Nice addition! 👍😄 I see one operation has been moved to defines, wondering if precalculating some values to minimize divisions and prioritize multiplications could suppose some performance improvement... or maybe compiler already takes care of those? |
Contributor
Author
Edit: Sorry, I'm tired, I just placed a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
glDrawElementsimplementation was missing (no idea how that got overlooked), and I also fixed the logic. I remember quickly gettingswDrawArraysworking with the immediate functions and that I needed to rewrite it up properly, but I totally forgot...Done!
simplescreenrecorder-2025-10-26_00.45.33.mp4