[rcore] Removing #pragma message and adding TRACELOG inside the function#5596
Merged
Conversation
Contributor
Author
|
Left it as Draft as I will test again on Windows. |
|
Just pointing out the irony after this post: https://x.com/raysan5/status/2026929451938808072 Good luck! |
Owner
|
@maiconpintoabreu thanks for the review! Maybe I'm further reviewing it to simplify it a bit... too many flags involved... |
Contributor
Author
|
@raysan5 maybe we could combine the warnings later and just say what it needs to run instead of a validation by "field". |
Owner
Yeah, that was my thought, it will be easier to read with same result, do you want to send another PR? |
Contributor
Author
|
@raysan5 sure I will do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making Warning message consistent and avoiding Warning every build by default.
Extra: Cosmetic refactor in
raymath