WebRGFW: remapping mouse/touch position to canvas pixel coordinates#5679
Merged
Conversation
…ports in raylib.h
…m choosing if-statements
Owner
|
@Crisspl please, could you review formatting to follow raylib code conventions? |
raysan5
reviewed
Mar 22, 2026
| } break; | ||
| case RGFW_mousePosChanged: | ||
| { | ||
| float event_x = 0.0f, event_y = 0.0f; |
| double canvasWidth = 0.0; | ||
| double canvasHeight = 0.0; | ||
| emscripten_get_element_css_size("#canvas", &canvasWidth, &canvasHeight); | ||
| event_x *= ((float)GetScreenWidth() / (float)canvasWidth); |
Owner
There was a problem hiding this comment.
Note raylib does not use spaces between / and *
Contributor
Author
|
sure, i will take care of it tommorow 🫡 |
Owner
|
@Crisspl thanks, I'm merging and reviewing it myself. |
Contributor
Author
|
oh, great. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually doing something very similar to what is done in rcore_web.
This probably should be fixed RGFW-side, but RGFW has more problems on web that should be addressed, so preapring this minimalistic change on the side of raylib is the best i could do here. Also opened an issue about this on RGFW repo: ColleagueRiley/RGFW#493