[examples] Fix memory out of bounds in [shapes] example - ball physics#5683
Merged
Conversation
Update screenshot to shapes_bouncing_ball.png
Owner
|
@Jopestpe Thanks for the review but... did you try it on Because this change is probably not related to the listed issue... |
Contributor
Author
My bad, I didn't mention it earlier, I tested it on both Linux and the web. Initially, reducing MAX_BALLS to 1300 or less didn't cause the memory out of bounds since as it fits within Emscripten's STACK_SIZE (64*1024), but I preferred to move it to the heap while keeping the 5000 from the original script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog