[rlgl] Remove forced normalization of normal vectors in rlNormal3f#5703
Merged
Conversation
…he user has set the correct input for the shader.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1617
to
+1626
| /* Normalize the vector if required. Default behavior assumes the normal vector is in the correct space for what the shader expects. | ||
| float length = sqrtf(normalx * normalx + normaly * normaly + normalz * normalz); | ||
| if (length != 0.0f) | ||
| { | ||
| float ilength = 1.0f/length; | ||
| normalx *= ilength; | ||
| normaly *= ilength; | ||
| normalz *= ilength; | ||
| } | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Owner
|
@JeffM2501 thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove forced normalization of normal vectors in rlNormal3f, assume the user has set the correct input for the shader. This allows users to use the batch system normals for special effects and custom lighting that may need to use a non unit magnitude.