[CORE] Unify raymath.h and raylib.h structure checks#5704
Closed
JeffM2501 wants to merge 2 commits into
Closed
Conversation
…es so they are not order dependent.
Owner
|
@JeffM2501 I prefer to avoid that change, one type should not be used if the other types are not defined |
Contributor
Author
|
That's what this does, ensure that once one type is used, the other is not, it just makes raylib behave that same way as raymath.h..... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes raylib.h check to see if math types like Vector2/3 and matrix are defined before defining them, in the same way that raymath.h does. Previously raylib.h assumed it was always setting the structures, and this forces raylib.h to be included before raymath.h.
This PR makes the include order not matter, making it much easier to include external libs that may use raymath or raylib in any order.
This should not break any compatibly, the same flags are set, just in a slightly different order during compilation.