Issue #5726 ( RL_DEFAULT_SHADER_UNIFORM_NAME_BONEMATRICES ) #5727
Merged
raysan5 merged 1 commit intoraysan5:masterfrom Apr 5, 2026
Merged
Issue #5726 ( RL_DEFAULT_SHADER_UNIFORM_NAME_BONEMATRICES ) #5727raysan5 merged 1 commit intoraysan5:masterfrom
raysan5 merged 1 commit intoraysan5:masterfrom
Conversation
Owner
|
@angshumankishore Good catch! thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first definition (line 1018) has a comment referencing RL_DEFAULT_SHADER_ATTRIB_LOCATION_BONEMATRICES (which seems like a copy-paste mistake, since this is a uniform, not an attribute).
The second definition (line 1053) has a clearer comment: "bone matrices (required for GPU skinning)".