Remap stb_vorbis malloc/free calls to RL_MALLOC/RL_FREE#5765
Closed
nadav78 wants to merge 4 commits into
Closed
Conversation
Added STB_VORBIS_MALLOC and STB_VORBIS_FREE hooks to stb_vorbis.c, consistent with the named macro pattern used by dr_wav, dr_mp3, and qoa.
Owner
|
@nadav78 I'm afraid |
Contributor
Author
|
My bad! Is there a preferred approach here? It seems like this would indeed need to be fixed upstream since stb_vorbis doesn't expose allocator hooks like the other libraries. |
Owner
|
@nadav78 I'm afraid there are not many options without modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the TODO in
src/raudio.c. Adds STB_VORBIS_MALLOC and STB_VORBIS_FREE hooks tostb_vorbis.c, consistent with the named macro pattern used by dr_wav, dr_mp3, and qoa. Previous PR #5763 used a raw#define mallocapproach which conflicted with stb_vorbis's internal stdlib.h include.