[rmodels] Removing powf function from CheckCollisionBoxSphere#5776
Merged
Conversation
CheckCollisionBoxSphere
Owner
|
@maiconpintoabreu thanks, I'm merging but it's not a change I specially like, the improvement is minimum and it adds dependency on other functions, that is something I always try to minimize. Main reason to merge is consistency with |
Contributor
Author
|
@raysan5 thanks, the main reason of the PR was to make it silimar to the other methods and more readable, the benchmark was to make sure that was no performance regression, the numbers are too small to see the improvement indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing powf with a similar way to calculate used in
CheckCollisionSpheresTest:
The benchmark on my machine the change did not improve a lot but it should improve on low end devices.
Changed the benchmark tool to use bench.h instead of poop (it was too noise)