[rtextures][rlgl] Fix pixel data size regressions#5984
Merged
raysan5 merged 1 commit intoJul 16, 2026
Conversation
Owner
|
@GideonSerf Oh! Thanks for the review! |
Contributor
Author
|
@raysan5 No problem 😊! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Recent pixel-size hardening added 64-bit variables to safely check image data sizes before converting them to
int. Some multiplication operands remainint, so the intermediate calculation may still occur at 32-bit width before assignment.Explicitly promoting the first operand ensures the calculation consistently uses 64-bit arithmetic across compilers.
ImageRotate()used the total destination image size as its per-pixel stride, causing out-of-bounds access for images larger than one pixel.Fix
GetPixelDataSize()andrlGetPixelDataSize().ImageRotate()allocation size and per-pixel stride as separate values.Validation
ImageRotate()overflow with MSVC AddressSanitizer.