refactor: modernize Go patterns across codebase

- Replace sort.Slice with slices.SortFunc and cmp.Compare
- Upgrade yaml.v2 to yaml.v3
- Replace gotest.tools with testify (already a dependency)
- Use context.Background() instead of context.TODO() in tests
- Use idiomatic errors.As with typed variables instead of new()
- Use %w for proper error wrapping in rollback handling
- Remove gotest.tools and yaml.v2 from go.mod

Author: ravisuhag

cli/config.go

@@ -8,7 +8,7 @@ import (
 	"github.com/raystack/compass/internal/config"
 	saltconfig "github.com/raystack/salt/config"
 	"github.com/spf13/cobra"
-	"gopkg.in/yaml.v2"
+	"gopkg.in/yaml.v3"
 )
 
 const configFlag = "config"

core/entity/search.go

@@ -1,8 +1,9 @@
 package entity
 
 import (
+	"cmp"
 	"context"
-	"sort"
+	"slices"
 
 	"github.com/raystack/compass/core/namespace"
 )
@@ -155,7 +156,7 @@ func reciprocalRankFusion(lists ...[]SearchResult) []SearchResult {
 	for _, s := range scores {
 		all = append(all, *s)
 	}
-	sort.Slice(all, func(i, j int) bool { return all[i].score > all[j].score })
+	slices.SortFunc(all, func(a, b scored) int { return cmp.Compare(b.score, a.score) })
 
 	results := make([]SearchResult, len(all))
 	for i, s := range all {

core/namespace/service_test.go

@@ -11,7 +11,7 @@ import (
 )
 
 func TestService_Create(t *testing.T) {
-	ctx := context.TODO()
+	ctx := context.Background()
 	mockedNamespace := &namespace.Namespace{
 		ID:       uuid.New(),
 		Name:     "tenant-1",
@@ -78,7 +78,7 @@ func TestService_Create(t *testing.T) {
 }
 
 func TestService_Update(t *testing.T) {
-	ctx := context.TODO()
+	ctx := context.Background()
 	mockedNamespace := &namespace.Namespace{
 		ID:       uuid.New(),
 		Name:     "tenant-1",

core/user/service_test.go

@@ -83,7 +83,7 @@ func TestValidateUser(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.Description, func(t *testing.T) {
-			ctx := context.TODO()
+			ctx := context.Background()
 			mockUserRepo := new(mocks.UserRepository)
 
 			if tc.Setup != nil {

core/validator/validator_test.go

@@ -4,7 +4,7 @@ import (
 	"testing"
 
 	"github.com/raystack/compass/core/validator"
-	"gotest.tools/assert"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestValidateStruct(t *testing.T) {
@@ -15,7 +15,7 @@ func TestValidateStruct(t *testing.T) {
 
 	type TestCase struct {
 		Description string
-		Struct      interface{}
+		Struct      any
 		ErrString   string
 	}
 

go.mod

@@ -33,8 +33,6 @@ require (
 	go.opentelemetry.io/otel/sdk/metric v1.42.0
 	golang.org/x/net v0.51.0
 	google.golang.org/protobuf v1.36.11
-	gopkg.in/yaml.v2 v2.4.0
-	gotest.tools v2.2.0+incompatible
 )
 
 require (
@@ -90,7 +88,7 @@ require (
 	golang.org/x/sys v0.41.0 // indirect
 	golang.org/x/term v0.40.0 // indirect
 	golang.org/x/text v0.34.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
+	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (

go.sum

@@ -374,10 +374,6 @@ gopkg.in/go-playground/assert.v1 v1.2.1 h1:xoYuJVE7KT85PYWrN730RguIQO0ePzVRfFMXa
 gopkg.in/go-playground/assert.v1 v1.2.1/go.mod h1:9RXL0bg/zibRAgZUYszZSwO/z8Y/a8bDuhia5mkpMnE=
 gopkg.in/ini.v1 v1.67.0 h1:Dgnx+6+nfE+IfzjUEISNeydPJh9AXNNsWbGP9KzCsOA=
 gopkg.in/ini.v1 v1.67.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
-gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
-gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
-gotest.tools v2.2.0+incompatible h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
-gotest.tools v2.2.0+incompatible/go.mod h1:DsYFclhRJ6vuDpmuTbkuFWG+y2sxOXAzmJt81HFBacw=

handler/user.go

@@ -78,13 +78,16 @@ func (server *Handler) StarEntity(ctx context.Context, req *connect.Request[comp
 
 	id, err := server.starService.Stars(ctx, ns, userID, req.Msg.GetEntityId())
 	if err != nil {
-		if errors.Is(err, star.ErrEmptyUserID) || errors.Is(err, star.ErrEmptyEntityID) || errors.As(err, new(star.InvalidError)) {
+		var invalidErr star.InvalidError
+		var userNotFoundErr star.UserNotFoundError
+		var duplicateErr star.DuplicateRecordError
+		if errors.Is(err, star.ErrEmptyUserID) || errors.Is(err, star.ErrEmptyEntityID) || errors.As(err, &invalidErr) {
 			return nil, connect.NewError(connect.CodeInvalidArgument, err)
 		}
-		if errors.As(err, new(star.UserNotFoundError)) {
+		if errors.As(err, &userNotFoundErr) {
 			return nil, connect.NewError(connect.CodeNotFound, err)
 		}
-		if errors.As(err, new(star.DuplicateRecordError)) {
+		if errors.As(err, &duplicateErr) {
 			return nil, connect.NewError(connect.CodeAlreadyExists, err)
 		}
 		return nil, internalServerError(ctx, "error starring entity", err)
@@ -101,10 +104,12 @@ func (server *Handler) UnstarEntity(ctx context.Context, req *connect.Request[co
 	}
 
 	if err := server.starService.Unstars(ctx, userID, req.Msg.GetEntityId()); err != nil {
-		if errors.Is(err, star.ErrEmptyUserID) || errors.Is(err, star.ErrEmptyEntityID) || errors.As(err, new(star.InvalidError)) {
+		var invalidErr star.InvalidError
+		var notFoundErr star.NotFoundError
+		if errors.Is(err, star.ErrEmptyUserID) || errors.Is(err, star.ErrEmptyEntityID) || errors.As(err, &invalidErr) {
 			return nil, connect.NewError(connect.CodeInvalidArgument, err)
 		}
-		if errors.As(err, new(star.NotFoundError)) {
+		if errors.As(err, &notFoundErr) {
 			return nil, connect.NewError(connect.CodeNotFound, err)
 		}
 		return nil, internalServerError(ctx, "error unstarring entity", err)

store/postgres/postgres.go

@@ -151,7 +151,7 @@ func (c *Client) RunWithinTx(ctx context.Context, f func(tx *sqlx.Tx) error) err
 	}
 	if err = f(tx); err != nil {
 		if txErr := tx.Rollback(); txErr != nil {
-			err = fmt.Errorf("rollback transaction error: %v (original error: %w)", txErr, err)
+			err = fmt.Errorf("rollback transaction error: %w (original error: %w)", txErr, err)
 		}
 
 		// reset context