Skip to content

Commit 2758b66

Browse files
committed
fix: fix CI test failures for postgres and elasticsearch
- Normalize RefreshedAt in test assertion helpers to avoid timestamp mismatch after insert/update now sets refreshed_at - Move ES_TEST_SERVER_URL env var from service container to job level so the runner process can discover the ES instance
1 parent 69e9e4b commit 2758b66

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ jobs:
1010
ports:
1111
- 9200:9200
1212
env:
13-
ES_TEST_SERVER_URL: "http://elasticsearch:9200"
13+
discovery.type: single-node
14+
xpack.security.enabled: "false"
15+
ES_JAVA_OPTS: "-Xms128m -Xmx128m"
16+
env:
17+
ES_TEST_SERVER_URL: "http://localhost:9200"
1418
steps:
1519
- uses: actions/checkout@v6
1620
- uses: actions/setup-go@v6

internal/store/postgres/asset_repository_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1829,11 +1829,13 @@ func (r *AssetRepositoryTestSuite) assertAsset(expectedAsset *asset.Asset, actua
18291829
// sanitize time to make the assets comparable
18301830
expectedAsset.CreatedAt = time.Time{}
18311831
expectedAsset.UpdatedAt = time.Time{}
1832+
expectedAsset.RefreshedAt = nil
18321833
expectedAsset.UpdatedBy.CreatedAt = time.Time{}
18331834
expectedAsset.UpdatedBy.UpdatedAt = time.Time{}
18341835

18351836
actualAsset.CreatedAt = time.Time{}
18361837
actualAsset.UpdatedAt = time.Time{}
1838+
actualAsset.RefreshedAt = nil
18371839
actualAsset.UpdatedBy.CreatedAt = time.Time{}
18381840
actualAsset.UpdatedBy.UpdatedAt = time.Time{}
18391841

@@ -1845,6 +1847,7 @@ func clearTimestamps(ast *asset.Asset) {
18451847
ast.UpdatedBy.UpdatedAt = time.Time{}
18461848
ast.CreatedAt = time.Time{}
18471849
ast.UpdatedAt = time.Time{}
1850+
ast.RefreshedAt = nil
18481851
}
18491852

18501853
func (r *AssetRepositoryTestSuite) assertProbe(t *testing.T, expected asset.Probe, actual asset.Probe) bool {

0 commit comments

Comments
 (0)