chore: add golangci-lint config and fix pre-existing lint issues

- Add .golangci.yml with errcheck and staticcheck enabled
- Exclude Close() errcheck via text pattern and exclude-functions
- Exclude QF1008 (embedded field selector) staticcheck suggestion
- Fix S1009: remove redundant nil checks before len() in discussion.go
- Fix QF1001: apply De Morgan's law in user.go
- Fix QF1008: remove embedded API field from ES test selectors

Author: ravisuhag

.golangci.yml

@@ -0,0 +1,21 @@
+version: "2"
+linters:
+  enable:
+    - errcheck
+    - staticcheck
+  settings:
+    errcheck:
+      exclude-functions:
+        - (io.Closer).Close
+        - (*database/sql.Conn).Close
+        - (*github.com/jmoiron/sqlx.Conn).Close
+        - (*google.golang.org/grpc.ClientConn).Close
+        - (github.com/ory/dockertest/v3.Resource).Close
+  exclusions:
+    rules:
+      - linters:
+          - errcheck
+        text: '\.Close'
+      - linters:
+          - staticcheck
+        text: 'QF1008'

core/discussion/discussion.go

@@ -100,15 +100,15 @@ func (d Discussion) ValidateConstraint() error {
 		return ErrInvalidState
 	}
 
-	if d.Assignees != nil && len(d.Assignees) > MAX_ARRAY_FIELD_NUM {
+	if len(d.Assignees) > MAX_ARRAY_FIELD_NUM {
 		return fmt.Errorf("assignees cannot be more than %d", MAX_ARRAY_FIELD_NUM)
 	}
 
-	if d.Assets != nil && len(d.Assets) > MAX_ARRAY_FIELD_NUM {
+	if len(d.Assets) > MAX_ARRAY_FIELD_NUM {
 		return fmt.Errorf("assets cannot be more than %d", MAX_ARRAY_FIELD_NUM)
 	}
 
-	if d.Labels != nil && len(d.Labels) > MAX_ARRAY_FIELD_NUM {
+	if len(d.Labels) > MAX_ARRAY_FIELD_NUM {
 		return fmt.Errorf("labels cannot be more than %d", MAX_ARRAY_FIELD_NUM)
 	}
 	return nil

internal/server/v1beta1/user.go

@@ -237,7 +237,7 @@ func (server *APIServer) buildGetDiscussionsFilter(req *compassv1beta1.GetMyDisc
 	}
 
 	if len(strings.TrimSpace(filterQuery)) > 0 {
-		if !(filterQuery == "created" || filterQuery == "all") {
+		if filterQuery != "created" && filterQuery != "all" {
 			filterQuery = "assigned" // default value
 		}
 	}

internal/store/elasticsearch/discovery_repository_test.go

@@ -108,7 +108,7 @@ func TestDiscoveryRepositoryUpsert(t *testing.T) {
 		err = repo.Upsert(ctx, ns, ast)
 		assert.NoError(t, err)
 
-		res, err := cli.API.Get(indexAlias, ast.ID)
+		res, err := cli.Get(indexAlias, ast.ID)
 		require.NoError(t, err)
 		require.False(t, res.IsError())
 
@@ -162,7 +162,7 @@ func TestDiscoveryRepositoryUpsert(t *testing.T) {
 		err = repo.Upsert(ctx, ns, newAsset)
 		assert.NoError(t, err)
 
-		res, err := cli.API.Get(indexAlias, existingAsset.ID)
+		res, err := cli.Get(indexAlias, existingAsset.ID)
 		require.NoError(t, err)
 		require.False(t, res.IsError())