Skip to content

Commit 6763d0d

Browse files
committed
fix: resolve test failures from asset-to-entity rename
- Fix missing comma in composite literal (extra closing brace from removed data wrapper) - Update execute_script_test.go to use newEntity instead of newAsset - Add expected labels:nil for feature_table entities in MultipleEntitiesFromResponse test
1 parent 92ad702 commit 6763d0d

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

plugins/extractors/http/execute_script_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"github.com/stretchr/testify/require"
1212
)
1313

14-
func TestNewAsset(t *testing.T) {
14+
func TestNewEntity(t *testing.T) {
1515
cases := []struct {
1616
typ string
1717
}{
@@ -31,7 +31,7 @@ func TestNewAsset(t *testing.T) {
3131
}
3232
for _, tc := range cases {
3333
t.Run(tc.typ, func(t *testing.T) {
34-
obj, err := newAsset(tc.typ)
34+
obj, err := newEntity(tc.typ)
3535
require.NoError(t, err)
3636

3737
m, ok := obj.(*tengo.Map)
@@ -47,8 +47,8 @@ func TestNewAsset(t *testing.T) {
4747
}
4848
}
4949

50-
func TestNewAssetEmptyType(t *testing.T) {
51-
_, err := newAsset("")
50+
func TestNewEntityEmptyType(t *testing.T) {
51+
_, err := newEntity("")
5252
require.Error(t, err)
5353
assert.Contains(t, err.Error(), "type must not be empty")
5454
}

plugins/extractors/http/http_extractor_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,7 @@ func TestExtract(t *testing.T) {
530530
},
531531
"create_time": "2022-08-08T03:17:54Z",
532532
"update_time": "2022-08-08T03:17:54Z",
533+
"labels": nil,
533534
"upstreams": []any{
534535
map[string]any{
535536
"urn": "urn:bigquery:celestial-dragons-staging:table:celestial-dragons-staging:feast.merchant_uuid_t2_discovery",
@@ -560,6 +561,7 @@ func TestExtract(t *testing.T) {
560561
},
561562
"create_time": "2022-09-19T22:42:04Z",
562563
"update_time": "2022-09-21T13:23:02Z",
564+
"labels": nil,
563565
"upstreams": []any{
564566
map[string]any{
565567
"urn": "urn:kafka:int-dagstream-kafka.yonkou.io:topic:GO_FOOD-delay-allocation-merchant-feature-10m-log",
@@ -673,7 +675,6 @@ func TestExtract(t *testing.T) {
673675
"STREAMS": structpb.NewStringValue(`[{"SOURCE_KAFKA_TOPIC_NAMES":"segmentation-message","INPUT_SCHEMA_PROTO_CLASS":"com.company.esb.segmentation.UpdateLogMessage","INPUT_SCHEMA_TABLE":"table1","SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_COMMIT_ENABLE":"false","SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET":"latest","SOURCE_KAFKA_CONSUMER_CONFIG_GROUP_ID":"data-test-external-voucher-dagger-0001","SOURCE_KAFKA_CONSUMER_CONFIG_BOOTSTRAP_SERVERS":"<REDACTED>","INPUT_SCHEMA_EVENT_TIMESTAMP_FIELD_INDEX":"3","SOURCE_KAFKA_NAME":"data-dagstream"}]`),
674676
}}),
675677
}}),
676-
}}),
677678
}},
678679
},
679680
{
@@ -733,7 +734,6 @@ func TestExtract(t *testing.T) {
733734
"STREAMS": structpb.NewStringValue(`[{"INPUT_SCHEMA_EVENT_TIMESTAMP_FIELD_INDEX":"4","INPUT_SCHEMA_PROTO_CLASS":"company.esb.cartography.erp.ERPMapMatchingLogV2Message","INPUT_SCHEMA_TABLE":"data_streams_0","SOURCE_DETAILS":[{"SOURCE_NAME":"KAFKA_CONSUMER","SOURCE_TYPE":"UNBOUNDED"}],"SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_COMMIT_ENABLE":"false","SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET":"latest","SOURCE_KAFKA_CONSUMER_CONFIG_BOOTSTRAP_SERVERS":"company-mainstream.company.io:6668","SOURCE_KAFKA_CONSUMER_CONFIG_GROUP_ID":"data-booking-map-matching-dagger-0002","SOURCE_KAFKA_NAME":"company-mainstream","SOURCE_KAFKA_TOPIC_NAMES":"aggregated-busy-driver-location-ping","SOURCE_PARQUET_FILE_DATE_RANGE":null,"SOURCE_PARQUET_FILE_PATHS":null}]`),
734735
}}),
735736
}}),
736-
}}),
737737
}},
738738
},
739739
{
@@ -774,7 +774,6 @@ func TestExtract(t *testing.T) {
774774
"STREAMS": structpb.NewStringValue(`[{"INPUT_SCHEMA_EVENT_TIMESTAMP_FIELD_INDEX":"5","INPUT_SCHEMA_PROTO_CLASS":"company.esb.booking.GoFoodBookingLogMessage","INPUT_SCHEMA_TABLE":"gofood_booking","SOURCE_DETAILS":[{"SOURCE_NAME":"KAFKA_CONSUMER","SOURCE_TYPE":"UNBOUNDED"}],"SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_COMMIT_ENABLE":"false","SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET":"latest","SOURCE_KAFKA_CONSUMER_CONFIG_BOOTSTRAP_SERVERS":"<REDACTED>","SOURCE_KAFKA_CONSUMER_CONFIG_GROUP_ID":"data-eim-driver-nearby-staging-dagger-0039","SOURCE_KAFKA_NAME":"company-mainstream","SOURCE_KAFKA_TOPIC_NAMES":"gofood-booking-log"},{"INPUT_SCHEMA_EVENT_TIMESTAMP_FIELD_INDEX":"1","INPUT_SCHEMA_PROTO_CLASS":"company.esb.gofood.NearbyEventMessage","INPUT_SCHEMA_TABLE":"gofood_nearby","SOURCE_DETAILS":[{"SOURCE_NAME":"KAFKA_CONSUMER","SOURCE_TYPE":"UNBOUNDED"}],"SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_COMMIT_ENABLE":"false","SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET":"latest","SOURCE_KAFKA_CONSUMER_CONFIG_BOOTSTRAP_SERVERS":"<REDACTED>","SOURCE_KAFKA_CONSUMER_CONFIG_GROUP_ID":"data-eim-driver-nearby-staging-dagger-0040","SOURCE_KAFKA_NAME":"company-mainstream","SOURCE_KAFKA_TOPIC_NAMES":"gofood-nearby-log"}]`),
775775
}}),
776776
}}),
777-
}}),
778777
}},
779778
},
780779
},

0 commit comments

Comments
 (0)